span + click handler does not make an accessible feature.
Please add: attr('tabIndex', 0).attr('role', 'button')
Version: master
Severity: enhancement
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=50793
Description
Description
Details
Details
- Reference
- bz50575
Related Objects
Related Objects
Event Timeline
Comment Actions
role=button makes sense but I don't understand why we would want to set tabIndex for it.
Comment Actions
tabIndex marks an element as focusable in the accessibility dom (which a span or div by default isn't). Alternatively, you can also just use an actual button of course.
https://developer.mozilla.org/en-US/docs/Accessibility/Keyboard-navigable_JavaScript_widgets
Comment Actions
Change 71784 had a related patch set uploaded by Santhosh:
Accessibility attributes for ULS trigger
Comment Actions
Change 71998 had a related patch set uploaded by Vogone:
Fixed import source for testwikidatawiki
Comment Actions
(In reply to comment #4)
Change 71998 had a related patch set uploaded by Vogone:
Fixed import source for testwikidatawiki
I'm sorry. This one is unrelated to this bug.