Page MenuHomePhabricator

Domino does not handle additive formatting elements correctly
Closed, ResolvedPublic

Description

<big>Foo<big>Bar</big>Baz</big> (html)

serialises to:

<big>Foo<big>Bar</big></big>Baz (wikitext)


Version: unspecified
Severity: normal

Details

Reference
bz50604

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 2:03 AM
bzimport added a project: Parsoid.
bzimport set Reference to bz50604.

This seems to be a domino bug:

domino.createDocument('<big>Foo<big>Bar</big>Baz</big>').outerHTML;
'<html><head></head><body><big>Foo<big>Bar</big></big>Baz</body></html>'

If this pull request is not merged soon, we can install the bugfix version @ https://github.com/subbuss/domino till it does.

I see this has been merged in master - do we need to do a new deploy for this?

We need a newer version of domino to be released. cscott (who I reassigned this bug to) will take care of that. And after that, we will have to update package.json and update production (I assume new modules will be pulled as part of that deploy). So, a couple more steps before this is in production.

This is landed locally. It just needs to be deployed to production now.

Are there any other additive formatting elements? Parsoid should handle them all correctly now, but the PHP parser still has problems with nested <em> and <b> (see bug 51081).

Per our fix on VE all elements should be considered additive as they may contain style="font-size: 110%"

New domino is in production. And parsoid handles nesting of all formatting elements (even though php parser may not -- which cscott has a fix for in core). Closing.