Page MenuHomePhabricator

Space inserted before link after single-character deletion
Closed, ResolvedPublic

Description

From https://en.wikipedia.org/wiki/Wikipedia:VisualEditor/Feedback#VE_adding_spaces.2C_messing_with_citation_access-dates:

I noticed something odd when using VisualEditor. I decided to use it when snooping around for various "it's" typos, for removing apostrophes seemed/is faster with VE than the old fashioned way. However, some of my edits seem to have done more than take out apostrophes. Seven times today ([http://en.wikipedia.org/w/index.php?title=Highcroft_Racing&diff=prev&oldid=562630195] [http://en.wikipedia.org/w/index.php?title=So_Emotional&diff=prev&oldid=562630132] [http://en.wikipedia.org/w/index.php?title=1988_in_British_television&diff=prev&oldid=562629968] [http://en.wikipedia.org/w/index.php?title=Olmaliq_FK&diff=prev&oldid=562629768] [http://en.wikipedia.org/w/index.php?title=FC_Jazz&diff=prev&oldid=562629613] [http://en.wikipedia.org/w/index.php?title=Brian_McDaniel&diff=prev&oldid=562629235] [http://en.wikipedia.org/w/index.php?title=Highlights_(band)&diff=prev&oldid=562629182]), VE added an extra space in a random place in the article (if it's hard to tell, on the last one it added the space right after "its"). And then it altered references on [http://en.wikipedia.org/w/index.php?title=God_of_War_(series)&diff=prev&oldid=562631132 another], including changing access-dates. I don't think that's supposed to happen... [[User:Greengreengreenred|<font color="#014421">Green</font>]][[User talk:Greengreengreenred|<font color="#50C878">green</font>]][[Special:Contribs/Greengreengreenred|<font color="#66FF00">green</font>]]<font color="red">red</font> 02:25, 3 July 2013 (UTC)

Might be a Parsoid bug based on selser tracing. There seems to be only a single space both in the original and the edited HTML.


Version: unspecified
Severity: normal

Details

Reference
bz50636

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 2:05 AM
bzimport added a project: Parsoid.
bzimport set Reference to bz50636.

Relevant part of the selser trace (note the extra space):

SS: ", an experimental racing car. The car was designed to reduce aerodynamic drag dramatically allowing for quicker straight and cornering speeds while using half as much power and half as much weight. Despite skepticism over the project, the DeltaWing made its debut at the "
SS: " "
SS: "[[2012 24 Hours of Le Mans]]"

Offhand, without having investigated this, it seems like a DSR issue.

In the accessdate example, the old markup is bad (duplicate accessdate); the second one apparently wins, which makes sense. However, there don't seem to be any actual changes in that paragraph, so it ideally shouldn't be affected at all.

Change 71757 had a related patch set uploaded by GWicke:
Bug 50636: Don't extrapolate DSR on change

https://gerrit.wikimedia.org/r/71757

The space issue will be fixed with the above patch. The accessdate diff (http://en.wikipedia.org/w/index.php?title=God_of_War_(series)&diff=prev&oldid=562631132) is bug 50637.

Change 71757 merged by jenkins-bot:
Bug 50636: Don't extrapolate DSR on change

https://gerrit.wikimedia.org/r/71757