Page MenuHomePhabricator

VisualEditor: Resizing an image which doesn't already have an explicit size set doesn't work
Closed, ResolvedPublic


What it says on the tin; if you resize an image, it with reports "this isn't a change, can't save" or saves and silently doesn't do anything.

Version: unspecified
Severity: normal



Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 2:06 AM
bzimport set Reference to bz50645.

Change 73965 had a related patch set uploaded by Esanders:
Create MWResizeableNode mixin to control defaultSize flag

Change 73965 merged by jenkins-bot:
Create MWResizeableNode mixin to control defaultSize flag

Fixed and will be going out in a few minutes.

  • Bug 51026 has been marked as a duplicate of this bug. ***

I'm not sure if this is the same issue, but as reported on English Wikipedia and tested by myself, using the image resizer to "Make full size" resulted in either a notice that no change had been made or a silent failure to save.

This was tested on FF26, W7 and Chrome 32.0.1700.107 m, W7.

The reporting editor concludes that "These new settings, for what they are worth, only work if the image already has a size indication (200px, 250px*250px, whatever), not when it only has a 'thumb' indication. Sadly, the latter is the default and by far most common situation."

He also questions the purpose of "Make full size", but I'll report that separately.