Enforce single-line context in the serializer
Closed, ResolvedPublic0 Estimated Story Points
Actions

Description

We need to enforce single-line syntactical context in headings and other line-based constructs (lists, paragraphs, etc pp).

Simple test case:

echo -e '<h2>\nfoo</h2>' | node parse --html2wt
==
foo==

Details

Reference: bz50683

	Subject	Repo	Branch	Lines +/-
	Enforce single-line context in the serializer	mediawiki/services/parsoid	master	+62 -5

Customize query in gerrit

Related Objects

Mentioned In: T100225: Move single-line-context-enforcement and meta-tag hoisting from headings to DOM normalization phase
rGPARdbd309d86c7b: Suppress separators in single-line context
rGPAR309233449927: Enforce single-line context in the serializer

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:09 AM

• bzimport added a project: Parsoid-Serializer.

• bzimport set Reference to bz50683.

• GWicke created this task.Jul 3 2013, 6:18 PM

This also happens in practice. Dogfooding example:
https://www.mediawiki.org/w/index.php?title=User%3AGWicke&diff=723931&oldid=655405

See also bug 51444. I'm not merging these bugs because 51444 is filed against VE, and I'm not sure that VE is blameless here (for including the newline in the heading to begin with).

Gwicke's initial commentary on this issue is at http://pastie.org/8146028

Arlolra removed • GWicke as the assignee of this task.Nov 25 2014, 7:09 PM

Arlolra added a project: Parsoid.

Arlolra set Security to None.

Arlolra removed a subscriber: MarkTraceur.

ssastry merged a task: T54484: Parsoid: Making a paragraph with forced line breaks in it a heading should strip the line breaks.Feb 4 2015, 10:47 PM

ssastry added subscribers: Jdforrester-WMF, Krinkle, • rmoen and 4 others.

ssastry moved this task from Needs Triage to VE Q3 on the Parsoid board.Feb 4 2015, 10:53 PM

Arlolra claimed this task.Feb 5 2015, 8:43 PM

• marcoil added a project: VisualEditor 2014/15 Q3 blockers.Feb 10 2015, 2:59 PM

Jdforrester-WMF moved this task from Nominated to Dependencies on the VisualEditor 2014/15 Q3 blockers board.Feb 10 2015, 7:43 PM

Jdforrester-WMF edited a custom field.Feb 10 2015, 8:31 PM

Jdforrester-WMF added a project: Blocked-on-Parsoid.Feb 13 2015, 9:39 PM

Arlolra merged a task: T70800: Parsoid list with newlines roundtrip issue: HTML "<ul><li>asd\nsdf</li></ul>" → Wikitext "* asd\nsdf" → HTML "<ul><li>asd</li></ul><p>sdf</p>".Mar 5 2015, 11:43 PM

Arlolra added subscribers: matmarex, • Whatamidoing-WMF, Aklapper and 2 others.

matmarex updated the task description. (Show Details)Mar 5 2015, 11:50 PM

Change 196246 had a related patch set uploaded (by Arlolra):
Enforce single-line context in the serializer

https://gerrit.wikimedia.org/r/196246

gerritbot added a project: Patch-For-Review.Mar 12 2015, 3:45 PM

Change 196246 merged by jenkins-bot:
Enforce single-line context in the serializer

https://gerrit.wikimedia.org/r/196246

Arlolra closed this task as Resolved.Mar 13 2015, 3:52 PM

Jdforrester-WMF moved this task from Dependencies to Done on the VisualEditor 2014/15 Q3 blockers board.Mar 13 2015, 11:40 PM

Jdforrester-WMF edited projects, added WMF-deploy-2015-03-18_(1.25wmf22); removed Patch-For-Review.Mar 16 2015, 3:09 PM

Arlolra mentioned this in rGPAR309233449927: Enforce single-line context in the serializer.Apr 8 2015, 4:28 PM

Arlolra mentioned this in rGPARdbd309d86c7b: Suppress separators in single-line context.May 23 2015, 3:47 PM

Arlolra mentioned this in T100225: Move single-line-context-enforcement and meta-tag hoisting from headings to DOM normalization phase.May 26 2015, 8:52 PM

Enforce single-line context in the serializerClosed, ResolvedPublic0 Estimated Story PointsActions

Description

Details

Related Objects

Event Timeline

Enforce single-line context in the serializer
Closed, ResolvedPublic0 Estimated Story Points
Actions