Page MenuHomePhabricator

MobileFrontend: 'Logged in as X' alert has weird appearance and shows up inconsistently
Closed, ResolvedPublic

Description

screen shot showing alert

One time, when I logged into en.m.wikipedia.org, I got a pop-up alert that said "Logged in as Kaldari". The alert looked rather strange (see attachment). In particular:

  • There were transparent stripes along the top and bottom
  • The font was pretty tiny

I've tried a dozen times on different browsers to reproduce this alert, but I've never been able to get it to show up again even after clearing cookies. It seems strange that if we're going to bother telling them they are logged in, we would only do it once. That might make people think that their subsequent logins failed. I was using Firefox and on the Beta site.


Version: unspecified
Severity: minor

Attached:

Details

Reference
bz50699

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 2:10 AM
bzimport added a project: MobileFrontend-beta.
bzimport set Reference to bz50699.
kaldari created this task.Jul 3 2013, 11:00 PM

It can be replicated at the following url in beta only (not alpha):
https://en.m.wikipedia.org/wiki/Main_Page?welcome=yes

It happens when you log in from the left menu
e.g.
visit in beta https://en.m.wikipedia.org/wiki/w/index.php?title=Special:UserLogin&returnto=Main+Page&returntoquery=welcome%3Dyes

I'm not seeing the lines.

Maryana should we kill this code or do we want to polish it up and merge it?

It worked for me when I followed your URL, but after I logged out and back in again, it didn't work. Somehow I seem to be losing the welcome=yes part along the way.

I do like the little extra confirmation it provides post-login, especially since we don't change the UI in any other way to indicate to users that they're logged in. We should make its behavior consistent with the other toasts, though (e.g., watchlist).

Maryana has suggested removing the code altogether (Stop abusing toasts)

Change 73123 had a related patch set uploaded by Jdlrobson:
Bug 50699: Remove the logged in toast notification

https://gerrit.wikimedia.org/r/73123

Change 73123 merged by jenkins-bot:
Bug 50699: Remove the logged in toast notification

https://gerrit.wikimedia.org/r/73123