Page MenuHomePhabricator

Gerrit: Comment parser for hashes includes loading whitespace in match (", <a href> 10fd1a3</a>")
Closed, ResolvedPublic

Description

Screenshot of problem

Attached:

Screen_Shot_2013-07-04_at_2.53.11_AM.png (134×970 px, 23 KB)

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 2:10 AM
bzimport added a project: Gerrit.
bzimport set Reference to bz50711.
bzimport added a subscriber: Unknown Object (MLST).

Gerrits autolinking capabilities are a bit limited.

To get around bug #45780, we had to check on the character before the
linked text. So this part get's linked as well.

It's the lesser of two evils to also link the space before the hash than
to mangle links as described in bug #45780.

Change 177106 had a related patch set uploaded (by Krinkle):
gerrit: Output space in commentlink "commit" before the link

https://gerrit.wikimedia.org/r/177106

Patch-For-Review

Change 177106 merged by Dzahn:
gerrit: Output space in commentlink "commit" before the link

https://gerrit.wikimedia.org/r/177106

Dzahn mentioned this in Unknown Object (Diffusion Commit).Dec 11 2014, 3:24 PM

has been applied on ytterbium

Krinkle removed Krinkle as the assignee of this task.
Krinkle claimed this task.
Krinkle updated the task description. (Show Details)
Krinkle removed a project: Patch-For-Review.
Krinkle set Security to None.