VisualEditor: Transclusion dialog sometimes shows items in "Add parameter" that are already used
Closed, ResolvedPublic

Description

Screenshot of problem

This causing:

  • The label fallback (parameter name + ucfirst) not working.
  • It is still available from the "Add parameter" dropdown.
  • The user can actually add it again, causing a logic error.

I can currently consistently reproduce this on https://en.wikipedia.org/wiki/Taal%2C_Batangas?veaction=edit when editing the "Population Consensus of Taal" information box.

See screenshot:

  • "title" is both in the sidebar and in the selectable cloud
  • "title" isn't transformed into "Title" (the templatedata has no .label for this one)

Version: unspecified
Severity: normal

Attached:

bzimport set Reference to bz50715.
Krinkle created this task.Via LegacyJul 4 2013, 4:01 AM
gerritbot added a comment.Via ConduitJul 10 2013, 7:06 PM

Change 73010 had a related patch set uploaded by Trevor Parscal:
Retain original param names and ignore leading/trailing whitespace

https://gerrit.wikimedia.org/r/73010

gerritbot added a comment.Via ConduitJul 10 2013, 10:57 PM

Change 73010 merged by jenkins-bot:
Retain original param names and ignore leading/trailing whitespace

https://gerrit.wikimedia.org/r/73010

Jdforrester-WMF added a comment.Via ConduitJul 10 2013, 11:03 PM

This is now fixed in master and we will push to production very soon. Sorry for the inconvenience.

Add Comment