Page MenuHomePhabricator

VisualEditor: Transclusion dialog sometimes shows items in "Add parameter" that are already used
Closed, ResolvedPublic


Screenshot of problem

This causing:

  • The label fallback (parameter name + ucfirst) not working.
  • It is still available from the "Add parameter" dropdown.
  • The user can actually add it again, causing a logic error.

I can currently consistently reproduce this on when editing the "Population Consensus of Taal" information box.

See screenshot:

  • "title" is both in the sidebar and in the selectable cloud
  • "title" isn't transformed into "Title" (the templatedata has no .label for this one)

Version: unspecified
Severity: normal


Screen_Shot_2013-07-04_at_6.00.22_AM.png (974×1 px, 123 KB)



Event Timeline

bzimport raised the priority of this task from to Unbreak Now!.Nov 22 2014, 2:11 AM
bzimport set Reference to bz50715.

Change 73010 had a related patch set uploaded by Trevor Parscal:
Retain original param names and ignore leading/trailing whitespace

Change 73010 merged by jenkins-bot:
Retain original param names and ignore leading/trailing whitespace

This is now fixed in master and we will push to production very soon. Sorry for the inconvenience.