Multiline comment followed by a space leads to the space being nowiki-escaped
Closed, ResolvedPublic

Description

https://en.wikipedia.org/w/index.php?title=Northrop_Loom&diff=562756829&oldid=543023104 added matching nowiki tags, but the change didn't actually include any markup - or, well, anything (it was an attempt to add a comma, which hasn't appeared).


Version: unspecified
Severity: normal

Details

Security
None
Reference
bz50758
bzimport set Reference to bz50758.
Ironholds created this task.Jul 4 2013, 4:54 PM

Belay that; comma appears, I'm just blind :). Still no reason for the nowikis I can see.

Original problem occurred on Firefox on Windows 7. I didn't replicate it, but another editor did with Chrome on Windows 7: http://en.wikipedia.org/w/index.php?title=User%3AEdgepedia%2FVE%2FNL&diff=562864059&oldid=562863922

This is reproducible; if you edit the original in VE https://en.wikipedia.org/w/index.php?title=User:Edgepedia/VE/NL&oldid=562863922&veaction=edit and make no changes it clean-diffs (selser to the rescue), but if you try to replicate the edit (add a comma anywhere in the paragraph after the "Economics" heading), the text following the multi-line HTML comment is escaped in <nowiki>s.

Simplified test case. Run this through wt2wt in Parsoid. " bar" will be nowiki escaped, but " foo" will not be.

<!--
--> foo

x <!--
--> bar

If you parse the above wikitext (ex: paste it in enwiki sandbox) " foo" will be rendered as preformatted text but " bar" is not. Parsoid handles that correctly.

But, the multiline comment followed by a space trips Parsoid's nowiki insertion code when converting the html to wikitext. It doesn't realize that " bar" will not be preformatted because the the comment did not start at the beginning of the line many lines up.

We'll look into this, but I suppose this is not a very common occurrence.

  • Bug 52266 has been marked as a duplicate of this bug. ***
Arlolra removed GWicke as the assignee of this task.Nov 25 2014, 7:10 PM
Arlolra added a project: Parsoid.
Arlolra set Security to None.
Arlolra removed a subscriber: MarkTraceur.
ssastry moved this task from Backlog to html2wt: nowikis on the Parsoid board.Dec 20 2014, 5:12 PM
marcoil moved this task from html2wt: nowikis to Backlog on the Parsoid board.Feb 13 2015, 12:47 PM
Arlolra closed this task as "Resolved".Aug 19 2015, 9:56 PM
Arlolra claimed this task.
Arlolra added a subscriber: Arlolra.

Parsoid handles the simplified test case above these days.

λ (master) cat t
<!--
--> foo

x <!--
--> bar

λ (master) cat t | node parse --wt2wt
<!--
--> foo

x <!--
--> bar

Add Comment