Multiline comment followed by a space leads to the space being nowiki-escaped
OpenPublic

Description

https://en.wikipedia.org/w/index.php?title=Northrop_Loom&diff=562756829&oldid=543023104 added matching nowiki tags, but the change didn't actually include any markup - or, well, anything (it was an attempt to add a comma, which hasn't appeared).


Version: unspecified
Severity: normal

bzimport added a project: Parsoid-Serializer.Via ConduitNov 22 2014, 1:44 AM
bzimport set Reference to bz50758.
Ironholds created this task.Via LegacyJul 4 2013, 4:54 PM
Ironholds added a comment.Via ConduitJul 4 2013, 5:12 PM

Belay that; comma appears, I'm just blind :). Still no reason for the nowikis I can see.

Mdennis-WMF added a comment.Via ConduitJul 4 2013, 7:06 PM

Original problem occurred on Firefox on Windows 7. I didn't replicate it, but another editor did with Chrome on Windows 7: http://en.wikipedia.org/w/index.php?title=User%3AEdgepedia%2FVE%2FNL&diff=562864059&oldid=562863922

Jdforrester-WMF added a comment.Via ConduitJul 12 2013, 2:25 PM

This is reproducible; if you edit the original in VE https://en.wikipedia.org/w/index.php?title=User:Edgepedia/VE/NL&oldid=562863922&veaction=edit and make no changes it clean-diffs (selser to the rescue), but if you try to replicate the edit (add a comma anywhere in the paragraph after the "Economics" heading), the text following the multi-line HTML comment is escaped in <nowiki>s.

ssastry added a comment.Via ConduitJul 12 2013, 2:38 PM

Simplified test case. Run this through wt2wt in Parsoid. " bar" will be nowiki escaped, but " foo" will not be.

<!--
--> foo

x <!--
--> bar

If you parse the above wikitext (ex: paste it in enwiki sandbox) " foo" will be rendered as preformatted text but " bar" is not. Parsoid handles that correctly.

But, the multiline comment followed by a space trips Parsoid's nowiki insertion code when converting the html to wikitext. It doesn't realize that " bar" will not be preformatted because the the comment did not start at the beginning of the line many lines up.

We'll look into this, but I suppose this is not a very common occurrence.

ssastry added a comment.Via ConduitJul 30 2013, 3:57 PM
  • Bug 52266 has been marked as a duplicate of this bug. ***
Arlolra placed this task up for grabs.Via WebNov 25 2014, 7:10 PM
Arlolra added a project: Parsoid.
Arlolra set Security to None.
Arlolra removed a subscriber: MarkTraceur.
Ironholds removed a subscriber: Ironholds.Via WebDec 5 2014, 7:45 PM
ssastry moved this task to html2wt: nowikis on the Parsoid workboard.Via WebDec 20 2014, 5:12 PM
RobLa-WMF added a project: Parsoid-Nowiki.Via WebFeb 11 2015, 8:10 PM
marcoil moved this task to Backlog on the Parsoid workboard.Via WebFeb 13 2015, 12:47 PM

Add Comment

Column Prototype
This is a very early prototype of a persistent column. It is not expected to work yet, and leaving it open will activate other new features which will break things. Press "\" (backslash) on your keyboard to close it now.