Page MenuHomePhabricator

Search suggestions box is misaligned in Konqueror 4.8.5
Closed, ResolvedPublic

Description

See https://commons.wikimedia.org/wiki/File:Knoq_search_monobook_and_vector.png

When using Koqueror 4.8.5 and entering any search term in the search box, the suggestions list always appears in the top left corner of the window/tab.

This seems independent of skin, wiki, and logged in/out status. Screenshots show monobook when logged in to en.wikipedia and vector when logged out of de.wikisource

This does not happen in Firefox 22, which is the only other graphical browser I have access to. I don't know how long this has been the case as Firefox is my normal browser and I was only using Konqueror to test a visual editor-related bug.


Version: 1.22.0
Severity: minor

Details

Reference
bz50805

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 1:48 AM
bzimport set Reference to bz50805.
Thryduulf created this task.Jul 5 2013, 2:45 PM

Oops, should have added that my system is Xubuntu Linux 12.04 LTS.

Thanks for taking the time to report this!

Confirming problem in Konqueror 4.10.4.

I guess this is another incarnation of bug 45668, do you agree?

It might be related to that bug, but I don't have anywhere near the knowledge required to say. Sorry.

It doesn't seem like bug 45668, that one was browser-independent. This one looks like a KHTML bug.

I don't have a Konqueror to test, but looking at the screenshots I suspect that jQuery's .offset() function is returning zeroes instead of real values. (Left position of the suggestions is zero, while top position appears to take into account the height of the search box, but not it's position.)

I actually installed Konqueror on my Windows XP just to test this.

Try it out at: http://www.quirksmode.org/dom/tests/rectangles.html

Konqueror simply doesn't support getting the position of an element. I'm pretty sure it's not possible to implement the same functionality for it.

Change 95871 had a related patch set uploaded by Bartosz Dziewoński:
mediawiki.searchSuggest: Blacklist Konqueror

https://gerrit.wikimedia.org/r/95871

Note: I cannot reproduce this problem in Konqueror 4.11.3 anymore.
It does not look awesome, but apart from being a few pixels off it's more or less in the correct place (below the search text input field on mediawiki.org).

As written in comment 2, this was still an issue in Konqueror 4.10.4.

Huh. Thanks for that, Andre, I updated the patch to only blacklist Konquerors older than 4.11.

I'd appreciate if you could test it, because I've been unable to get Ubuntu 12 to install a Konqueror newer than 4.8, and I've downloaded enough VMs for today.
(I did verify that 4.8 gets blacklisted.)

MatmaRex: Not sure how to quickly test this, sorry... :-(

  • Install a MediaWiki
  • Apply or checkout that patch
  • Verify that no search suggestions appear when you type in the search field on Konqueror < 4.11 (make sure your wiki has some pages first)
  • Verify that search suggestions do appear on Konqueror >= 4.11 and other browsers and are correctly placed near the search field

:)

Change 95871 merged by TheDJ:
mediawiki.searchSuggest: Blacklist Konqueror < 4.11

https://gerrit.wikimedia.org/r/95871