Page MenuHomePhabricator

After adding documentation, "Add documentation" should be "Edit documentation"
Closed, ResolvedPublic

Description

To add documentation for a string that has no documentation yet, one can click "Add documentation" in the translation editor. Once that is done, and the documentation has been saved, the link still reads "Add documentation". It should be "Edit documentation".

Steps to reproduce:

  1. Open a message in translation editor that has no docs yet.
  2. Click "Add documentation"
  3. Enter text
  4. Save documentation

Observed:
I. Link to add or update documentation reads "Add documentation" while there is documentation now.

Expected:
II. After adding initial documentation, link to edit documentation should read "Edit documentation".

Easy?


Version: master
Severity: minor

Details

Reference
bz50954

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 1:58 AM
bzimport set Reference to bz50954.
siebrand created this task.Jul 8 2013, 4:34 PM

mailstorpk wrote:

Where is exactly the Add documentation function defined?

(In reply to Siebrand Mazeland from comment #0)

Easy?

Nikerabbit> BPositive: 50954 shouldn't be too hard

pr4tiklahoti wrote:

(In reply to Nemo from comment #2)

(In reply to Siebrand Mazeland from comment #0)

Easy?

Nikerabbit> BPositive: 50954 shouldn't be too hard

Yes, I will work on this. Thanks.

Change 114696 had a related patch set uploaded by BPositive:
'Add Documentation' link now changes to 'Edit Documentation' on adding the Documentation

https://gerrit.wikimedia.org/r/114696

Change 114745 had a related patch set uploaded by BPositive:
'Add documentation' link now changes to 'Edit documentation' as soon as qqq exists

https://gerrit.wikimedia.org/r/114745

Change 114745 abandoned by Nikerabbit:
'Add documentation' link now changes to 'Edit documentation' as soon as qqq exists

Reason:
Integrated into parent.

https://gerrit.wikimedia.org/r/114745

Change 114696 merged by jenkins-bot:
'Add documentation' link now changes to 'Edit documentation' as soon as qqq exists

https://gerrit.wikimedia.org/r/114696

Congrats for your first bug fix, I hope to see many more soon!