Page MenuHomePhabricator

UserMailer.php - needs a small correction
Closed, ResolvedPublic

Description

Please can a developer delete these three lines 351 ff in UserMailer.php

if( !$timecorrection ) {
      # fail safe
     $timecorrection = '00:00';
}

These lines - even when they were intended as a fail-safe - _break_ a
potentially given $wgLocalTZoffset value, with which the sysop can force a
certain offset of all time displays.

Without the three lines, it will also correctly work in enotifs:

  • Users having a timecorrection _set_ in their preferences, receive enotifs with

page edit times expressed in their local time

  • User w/o a timecorrection (i.e. empty field) receive enotif with the _local_

time (= servertime + $wgLocalTZoffset, as intended)


Version: 1.5.x
Severity: normal

Details

Reference
bz3307

Related Objects

StatusSubtypeAssignedTask
ResolvedNone
ResolvedNone

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 8:47 PM
bzimport set Reference to bz3307.

related to bugzilla http://bugzilla.wikipedia.org/show_bug.cgi?id=3305 and 454
(enotif) and 505 (timezone issues)

(In reply to comment #0)

Please can a developer delete these lines 351 ff in UserMailer.php

if( !$timecorrection ) {
      # fail safe
     $timecorrection = '00:00';
}

this part should be really removed, pls.

robchur wrote:

Modified UserMailer.php

I've proposed the modified version in the attachment.

attachment UserMailer.php ignored as obsolete

zigger wrote:

(Please add wikibugs-l@wikipedia.org to the CC list when assigning bugs.)

robchur wrote:

Actual patch

This is the actual patch file, in the expected format; the previous one was the
whole PHP script, as I didn't have access to my CVS client at the time.

Attached: