Page MenuHomePhabricator

Render paragraphs when indent-pre is suppressed in blocklevels such as blockquote
Closed, ResolvedPublic

Description

Test case:

<blockquote>
  foo

  bar
</blockquote>

Expected result:
Two paragraphs.

Actual result:
No paragraph at all, likely due to indent-p / paragraph wrapper interaction.

Note that:

<blockquote>
foo

bar
</blockquote>

…works correctly.

Details

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 1:50 AM
bzimport added a project: Parsoid.
bzimport set Reference to bz51262.

The PHP parser discussion is actually bug 51086.

Note that:
<blockquote>
foo

bar
</blockquote>

works already. It's just the leading-indent version which doesn't -- because the <pre> tags get stripped inside the blockquote in a later stage.

Might be related to bug 52761.

Note that the PHP parser creates <pre>s for the test case specified in the description now.

PHP fix is actually bug 6200. And there are no <pre>s from the PHP parser now.

I think subbu was hacking on the indent-pre stuff recently.

Change 110651 had a related patch set uploaded by Arlolra:
Render paragraphs when indent-pre is suppressed in blocklevels

https://gerrit.wikimedia.org/r/110651

Change 110651 merged by jenkins-bot:
Render paragraphs when indent-pre is suppressed in blocklevels

https://gerrit.wikimedia.org/r/110651

The original test case was fixed here: https://git.wikimedia.org/commit/mediawiki%2Fservices%2Fparsoid.git/12405fbcd0ba39a889914613d828934d9482c721

but we still need to investigate the PHP parser's behaviour for other blocklevels besides blockquote.

ssastry set Security to None.
matmarex added a subscriber: matmarex.

This has been fixed in 2014 and only kept open to "investigate the PHP parser's behaviour for other blocklevels" per comment above. Is there any investigation needed still or can we close it? ;)

Resolving. @Arlolra feel free to reopen if you are going to look at this.

Change 414747 had a related patch set uploaded (by Arlolra; owner: Arlolra):
[mediawiki/services/parsoid@master] Remove fixme in handlepres

https://gerrit.wikimedia.org/r/414747

Change 414747 merged by jenkins-bot:
[mediawiki/services/parsoid@master] Remove fixme in handlepres

https://gerrit.wikimedia.org/r/414747