Page MenuHomePhabricator

API prop=imageinfo is not returning correct iicontinue when image title is not the same as the dbkey
Closed, ResolvedPublic

Description

When querying imageinfo

  • for multiple titles (When requesting just one title, it uses iistart for query-continuation.)
  • with thumburl requested
  • for a file with more revisions than the API will output thumburls

the API returns a query-continue that, when used will return the same results and the same query-continue:

https://commons.wikimedia.org/w/api.php?format=jsonfm&action=query&prop=imageinfo&iiprop=url&titles=File:Susy%20Zerfall%20chi0.svg|File:Samesex%20marriage%20in%20USA.svg&iiurlwidth=120&iilimit=500&iicontinue=Samesex%20marriage%20in%20USA.svg|20110701173547

which gives:
{

"query-continue": {
    "imageinfo": {
        "iicontinue": "Samesex marriage in USA.svg|20110701173547"
    }
},
"query": {
    "pages": {

...

My client picks-up the
"iicontinue": "Samesex marriage in USA.svg|20110701173547"
and sends it back to the API.


Version: 1.22.0
Severity: normal

Details

Reference
bz51342

Event Timeline

bzimport raised the priority of this task from to Normal.Nov 22 2014, 1:55 AM
bzimport added a project: MediaWiki-API.
bzimport set Reference to bz51342.
Rillke created this task.Jul 15 2013, 7:33 AM

Why is this of low priority? If many clients use a similar query you DDoS yourself.

Perhaps I should explicitly mention that I do not get the data I requested?

More specifically, the bug appears to be that it is not paying attention to the iicontinue value at all. The same results are being returned whether iicontinue is passed or not.

Ok, I've tracked it down. Gerrit change to be posted shortly.

Change 73762 had a related patch set uploaded by Anomie:
API: Fix prop=imageinfo iicontinue

https://gerrit.wikimedia.org/r/73762

Thank you. That was fast.

Change 73762 merged by jenkins-bot:
API: Fix prop=imageinfo iicontinue

https://gerrit.wikimedia.org/r/73762

Change is now merged. It should be deployed on WMF wikis along with 1.22wmf11, see https://www.mediawiki.org/wiki/MediaWiki_1.22/Roadmap for the schedule.