Page MenuHomePhabricator
Create Task
Maniphest T53448

ParserTests: incrementally --updateKnownFailures when used with --filter option
Open, LowPublic
Actions

Description

when --filter and --updateKnownFailures are used together, update deletes entries for all other tests. Fix parser tests script to make them play well together.

Details

Reference
bz51448

Event Timeline

• bzimport raised the priority of this task from to Low.Nov 22 2014, 2:03 AM
• bzimport added a project: Parsoid-Tests.
• bzimport set Reference to bz51448.
ssastry created this task.Jul 16 2013, 4:43 PM
cscott added a comment.Jul 16 2013, 5:26 PM

The easiest thing would be for --rewrite-blacklist to fail with an error if --filter was specified.

But you want something different, it seems? To keep all the existing blacklist entries which don't match the filter, and just rewrite the filtered ones?

ssastry added a comment.Jul 16 2013, 5:36 PM

The former would be good, and the latter would be better. It can even be two different tasks.

gerritbot added a comment.Jul 16 2013, 6:02 PM

Change 73984 had a related patch set uploaded by Cscott:
Sanity check --rewrite-blacklist: don't allow simultaneous --filter.

https://gerrit.wikimedia.org/r/73984

gerritbot added a comment.Jul 16 2013, 6:40 PM

Change 73984 merged by jenkins-bot:
Sanity check --rewrite-blacklist: don't allow simultaneous --filter.

https://gerrit.wikimedia.org/r/73984

cscott added a comment.Aug 16 2013, 4:58 PM

Retitling the bug to accomodate the second half of subbu's feature request.

Arlolra removed • GWicke as the assignee of this task.Nov 25 2014, 7:15 PM
Arlolra added a project: Parsoid.
Arlolra set Security to None.
ssastry moved this task from Needs Triage to Testing on the Parsoid board.Dec 20 2014, 4:15 AM
• marcoil moved this task from Testing to Needs Triage on the Parsoid board.Feb 13 2015, 12:51 PM
Liuxinyu970226 subscribed.Jan 26 2017, 9:41 AM
MarkTraceur unsubscribed.Jan 27 2017, 10:22 PM
ssastry moved this task from Needs Triage to Testing on the Parsoid board.Dec 18 2017, 10:08 PM
Arlolra renamed this task from ParserTests: incrementally rewrite-blacklist when used with --filter option to ParserTests: incrementally --updateKnownFailures when used with --filter option.Mar 23 2022, 7:42 PM
Arlolra updated the task description. (Show Details)
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits