Page MenuHomePhabricator

ParserTests: incrementally rewrite-blacklist when used with --filter option
Open, LowPublic

Description

when --filter and --rewrite-blacklist is used together, rewrite deletes entries for all other tests. Fix parser tests script to make them play well together.


Version: unspecified
Severity: normal

Details

Reference
bz51448

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 2:03 AM
bzimport added a project: Parsoid-Tests.
bzimport set Reference to bz51448.
ssastry created this task.Jul 16 2013, 4:43 PM

The easiest thing would be for --rewrite-blacklist to fail with an error if --filter was specified.

But you want something different, it seems? To keep all the existing blacklist entries which don't match the filter, and just rewrite the filtered ones?

The former would be good, and the latter would be better. It can even be two different tasks.

Change 73984 had a related patch set uploaded by Cscott:
Sanity check --rewrite-blacklist: don't allow simultaneous --filter.

https://gerrit.wikimedia.org/r/73984

Change 73984 merged by jenkins-bot:
Sanity check --rewrite-blacklist: don't allow simultaneous --filter.

https://gerrit.wikimedia.org/r/73984

Retitling the bug to accomodate the second half of subbu's feature request.

Arlolra removed GWicke as the assignee of this task.Nov 25 2014, 7:15 PM
Arlolra added a project: Parsoid.
Arlolra set Security to None.
ssastry moved this task from Backlog to Testing on the Parsoid board.Dec 20 2014, 4:15 AM
marcoil moved this task from Testing to Backlog on the Parsoid board.Feb 13 2015, 12:51 PM
ssastry moved this task from Backlog to Testing on the Parsoid board.Dec 18 2017, 10:08 PM