Page MenuHomePhabricator

returnTo link layout wrong if no JavaScript
Closed, ResolvedPublic

Description

detail of Getting Started page displayed after account creation on en-beta

If you disable JavaScript and create an account on a wiki that has Extension:GettingStarted, the returnto link that appears on the bottom of the "Welcome, $Username!" getting started page appears strangely (see attachment). Instead of "Return to _Page title_." the link appears out of sequence below and to the left of "Return to.".

This happens because Special:GS loads CSS (resources/ext.gettingstarted.css) that styles '#mw-returnto a' as "display: block, float: left". JavaScript (resources/ext.gettingstarted.test.accountCreation.js) removes the "Return to " and "." text surrounding the link, avoiding the bug. I think '#mw-returnto a' CSS is from when the returnto was an Agora-style button, and is obsolete.

The introduction of CentralAuth/SUL2's silent redirect has disabled Special:GS on account creation, and the way GettingStarted works is likely to change, hence minor severity and priority.


Version: master
Severity: minor

Attached:

Details

Reference
bz51595

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 1:44 AM
bzimport set Reference to bz51595.

Change 74414 had a related patch set uploaded by Spage:
Remove styling from returnto link

https://gerrit.wikimedia.org/r/74414

Change 74414 merged by jenkins-bot:
Remove styling from returnto link

https://gerrit.wikimedia.org/r/74414

swalling wrote:

Testing patch 74414 on labs looks okay with JS and removes redundant code, but this _doesn't_ fix the unnecessary line break for users without JS.

(In reply to comment #3)

this _doesn't_ fix the unnecessary line break for users without JS.

Can you show me or take a screen shot? In Firefox on en.wikipedia.beta.wmflabs.org I see a clean "Return to Main Page" on one line.

swalling wrote:

(In reply to comment #4)

(In reply to comment #3)

this _doesn't_ fix the unnecessary line break for users without JS.

Can you show me or take a screen shot? In Firefox on
en.wikipedia.beta.wmflabs.org I see a clean "Return to Main Page" on one
line.

I was testing on w2 where the SUL2 stuff was as well. I guess it didn't have the patch when I tested, because Beta Labs looks okay in Chrome and FF.