Page MenuHomePhabricator

Echo: Don't override behaviour of link underline for inline links
Closed, ResolvedPublic

Description

The default in Vector was set to be hidden by default and show them on hover (for UX reasons I believe). MediaWiki allows users to change this through preferences.

Either way, the behaviour is set and is expected to be reflected and not overridden.

I don't know if it is intentional (since it isn't consistently done), but the main link inside an Echo item in the overlay has CSS set to enforce the underline to be hidden at all times.

The "View edit" link on the contrary works as expected and shows an underline on-hover (e.g. it does whatever the skin or user has set).

The "All notifications" and "Preferences" links on the bottom also have this restriction set, though I think it makes sense for those as those are block level (the entire width/padding a click target), more like buttons.

For consistency the underline property should not be set to either none or underline for inline links.

This can be fixed by removing "text-decoration: none;" from the "#p-personal .mw-echo-title a:hover" rule in ext.echo.overlay.css (submitting a patch in a second).

I noticed that for the Modern skin it is going to be more tricky since that skin has a rule to hide the underline inside #p-personal (because the Modern skin displays the personal portlet links as buttons instead of links). Inside regular content (like the Echo overlay items) it is intended to behave like previously described for Vector. I don't see any way to reasonably fix this in Modern other than to move the Echo overlay container out of #p-personal so that it isn't an absolutely positioned block level element injected into a list item for the personal portlet links, but an absolutely positioned element in the same visual location, but outside of that list in the DOM (which is probably something that should be done anyway to fix other nasty edge cases with the layout).


Version: unspecified
Severity: normal

Details

Reference
bz51617

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 1:45 AM
bzimport added a project: Notifications.
bzimport set Reference to bz51617.
bzimport added a subscriber: Unknown Object (MLST).
Krinkle created this task.Jul 18 2013, 3:35 PM

Created attachment 12884
Screenshot where the two links are hovered (composed image), but the bold one has underline overruled.

Attached:

Change 74374 had a related patch set uploaded by Krinkle:
Remove override of skin behaviour for inline anchor's text-docaration

https://gerrit.wikimedia.org/r/74374

(In reply to comment #0)

I don't see any way to reasonably fix this
in
Modern other than to move the Echo overlay container out of #p-personal so
that
it isn't an absolutely positioned block level element injected into a list
item
for the personal portlet links, but an absolutely positioned element in the
same visual location, but outside of that list in the DOM (which is probably
something that should be done anyway to fix other nasty edge cases with the
layout).

Previously suggested on Id8dd1454 and bug 47993 and bug 47932 and I think a few other bugs as well.

I agree it is inconsistent, both with the rest of the skin and other parts of Echo. However this was intentional per the designer. CCing Vibha.

If Vibha doesn't have any objections, I'm fine with merging the patch.

Change 74374 merged by jenkins-bot:
Remove override of skin behaviour for inline anchor's text-decoration

https://gerrit.wikimedia.org/r/74374