Page MenuHomePhabricator

ModifyEntityTestBase and related api tests need refactoring
Closed, ResolvedPublic

Description

ModifyEntityTestBase is doing very bad stuff and is written very poorly.

It is in desperate need of refactoring and same goes for any related api tests that are using code from ModifyEntityTestBase.


Version: master
Severity: major
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=51570

Details

Reference
bz51681

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 1:50 AM
bzimport set Reference to bz51681.
bzimport added a subscriber: Unknown Object (MLST).
aude created this task.Jul 19 2013, 1:17 PM

I have been working on this all week, took a while to make sure I started in the right place, as naturally if you change one thing somewhere it breaks everything everywhere else...

Initial path is https://gerrit.wikimedia.org/r/78364 which changes the way entities are created and managed for the tests as well as implementing is usage in all tests that mess about with entities.
This means it is now safe to fix all of the tests without worrying about bad id values etc.

Also https://gerrit.wikimedia.org/r/78368 refactors the SetDescription/Label test and their base to make them better! :)

Still a long way to go refactoring all of the other tests and making sure they actually test what we want.

Change 78368 had a related patch set uploaded by Addshore:
Refactor LangAttribute Api Test Cases

https://gerrit.wikimedia.org/r/78368

Change 78364 had a related patch set uploaded by Addshore:
Refactor EntityTestBase

https://gerrit.wikimedia.org/r/78364

Change 78078 had a related patch set (by Addshore) published:
Refactor SetAliasesTest

https://gerrit.wikimedia.org/r/78078

Change 78364 merged by jenkins-bot:
Refactor EntityTestBase

https://gerrit.wikimedia.org/r/78364

Change 78368 merged by jenkins-bot:
Refactor LangAttribute Api Test Cases

https://gerrit.wikimedia.org/r/78368

Change 78078 merged by jenkins-bot:
Refactor SetAliasesTest

https://gerrit.wikimedia.org/r/78078