Page MenuHomePhabricator

VisualEditor: Auto-hide "You've entered wikimarkup" warning when the user has removed the markup
Closed, ResolvedPublic

Description

At the moment wikimarkup being entered into the VE triggers a notice warning the user that it won't work - this notice then has to be actively dismissed. It'd be nice if, should the user remove the problematic markup, the notice would vanish.

I'm popping this in as a low-priority enhancement: I appreciate the VE team has active breakage to focus on.


Version: unspecified
Severity: enhancement
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=52386
https://bugzilla.wikimedia.org/show_bug.cgi?id=70168

Details

Reference
bz51701

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 1:51 AM
bzimport set Reference to bz51701.

*** Bug 52155 has been marked as a duplicate of this bug. ***

The popup should also be closed automatically after the "save page" button has been pressed. At that point it's clear that the user is not going to remove any markup that still remains (for whatever reason) so the notice serves no other purpose and just gets in the way of the edit summary dialog.

(In reply to comment #2)

The popup should also be closed automatically after the "save page" button
has
been pressed. At that point it's clear that the user is not going to remove
any
markup that still remains (for whatever reason) so the notice serves no other
purpose and just gets in the way of the edit summary dialog.

There's an issue with this though, in that the popup hovers over the 'Save page' button so I couldn't actually click 'Save page' very easily. It wasn't at all clear to me that clicking anywhere on the popup would close it.

(In reply to comment #3)

There's an issue with this though, in that the popup hovers over the 'Save
page' button so I couldn't actually click 'Save page' very easily. It wasn't
at
all clear to me that clicking anywhere on the popup would close it.

You aren't the first person to say that - see bug 52386

Change 110295 had a related patch set uploaded by Alex Monk:
Hide wikitext warning notification when the user removes the markup

https://gerrit.wikimedia.org/r/110295

Change 110295 merged by jenkins-bot:
Hide wikitext warning notification when the user removes the markup

https://gerrit.wikimedia.org/r/110295

That area of code could do with some rethinking, but this is basically done.