Page MenuHomePhabricator

VisualEditor: Warning for blank reference list is confusing
Closed, ResolvedPublic

Description

Removing the last reference on a page, with <references/> present, causes the waring:

There are no references with the group "" on this page.

That should be

There are no references on this page.


Version: unspecified
Severity: enhancement

Details

Reference
bz51873

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 2:02 AM
bzimport set Reference to bz51873.
jayvdb created this task.Jul 23 2013, 11:59 AM

(In reply to comment #0)

Removing the last reference on a page, with <references/> present, causes the
waring:

There are no references with the group "" on this page.

That should be

There are no references on this page.

No. You can have dozens of <ref group="foo">s and no <ref>s and get that message.

Perhaps a special-case of "There are no references without a group on this page." for the null-group instance?

In the use-case for this bug, there are no references of any group, so why mention groups at all. IMO the UI shouldnt talk about groups unless it is necessary. Most pages dont used grouped references.

I agree with John: Most pages dont used grouped references. It would be much more intuitive to say that there are no references at all. Several users in the Hebrew Wikipedia complained about it, and I imagine that it's the same in all languages.

Change 86656 had a related patch set uploaded by Esanders:
Add specific message for empty ref group list

https://gerrit.wikimedia.org/r/86656

Change 86656 merged by jenkins-bot:
Add specific message for empty ref group list

https://gerrit.wikimedia.org/r/86656