Page MenuHomePhabricator

VisualEditor: A <nowiki> on page causes "Uncaught RangeError: Maximum call stack size exceeded" in oojs.compare
Closed, ResolvedPublic

Description


Version: unspecified
Severity: major

Details

Reference
bz51948

Event Timeline

bzimport raised the priority of this task from to Unbreak Now!.Nov 22 2014, 2:08 AM
bzimport set Reference to bz51948.
Amire80 created this task.Jul 24 2013, 10:17 AM

[Sorry, somehow it was created without a description.]

On the latest master I cannot edit a page that has <nowiki> in it. VisualEditor appears to be loading with the "progress bar", but doesn't go to actual editing mode.

Versions:
VisualEditor 393807462e9d04ec5e437cb50ef1d03e5644e9be
Parsoid be8a7dea49bd70692ef574a1bb7c7a70584d77e3
core e617dc6c8f2ce1d867ddadcd4bc3de098a84ff07

Change 75636 had a related patch set uploaded by Jforrester:
Put <nowiki> edting in experimental for now

https://gerrit.wikimedia.org/r/75636

Change 75636 merged by jenkins-bot:
Put <nowiki> edting in experimental for now

https://gerrit.wikimedia.org/r/75636

https://www.mediawiki.org/w/index.php?title=Extension:MassMessage/Design&oldid=745378&veaction=edit

When I go to this URL in Google Chrome/OS X/Version 27.0.1453.116, I get the following error in my JavaScript console:

Uncaught RangeError: Maximum call stack size exceeded
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare

(In reply to comment #4)

https://www.mediawiki.org/w/index.php?title=Extension:MassMessage/
Design&oldid=745378&veaction=edit
When I go to this URL in Google Chrome/OS X/Version 27.0.1453.116, I get the
following error in my JavaScript console:
Uncaught RangeError: Maximum call stack size exceeded
oo.compare
oo.compare

[…]

This is now masked by some significant performance improvements we made (so it "works"), but we think it's still an issue; keeping open.

Change 76220 had a related patch set uploaded by Jforrester:
Don't compare annotations directly with ve.compare()

https://gerrit.wikimedia.org/r/76220

Change 76220 merged by jenkins-bot:
Don't compare annotations directly with ve.compare()

https://gerrit.wikimedia.org/r/76220