Maniphest T54057

UploadBlacklist needs a comment tweak
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• MZMcBride
	Jul 25 2013, 9:20 PM

Tags

Referenced Files

None

Subscribers

Description

From https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FUploadBlacklist.git/e996b431806a6bf6e045a3dccd642b0e28cbb127/UploadBlacklist.php:

Callback for UploadVerification hook; calculates the file's
MD5 hash and checks it against a list of blacklisted files.
If it matches, the upload will be denied. ---

$hash = sha1_file( $tempName );

The comment is wrong/outdated.

Version: master
Severity: normal

Details

Reference: bz52057

Event Timeline

• bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 1:49 AM

• bzimport added projects: MediaWiki-extensions-Other, good first task.

• bzimport set Reference to bz52057.

• MZMcBride created this task.Jul 25 2013, 9:20 PM

Change 76010 had a related patch set uploaded by Legoktm:
UploadBlacklist uses sha1 hash, not md5

https://gerrit.wikimedia.org/r/76010

Change 76010 merged by jenkins-bot:
UploadBlacklist uses sha1 hash, not md5

https://gerrit.wikimedia.org/r/76010

Peachey88 edited projects, added MediaWiki-extensions-UploadBlacklist; removed MediaWiki-extensions-Other.Feb 23 2020, 1:01 AM