Maniphest T54214

Wikidata logo incorrect
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	zhuyifei1999
	Jul 29 2013, 11:37 AM

Tags

Referenced Files

	F11599: Wikidata_logo.patch
	Nov 22 2014, 2:00 AM

Subscribers

View All 11 Subscribers

Tokens

"100" token, awarded by Liuxinyu970226.

Description

For example https://incubator.wikimedia.org/wiki/Wp/zh has an English Wikipedia logo instead of Wikidata's.

Details

Reference: bz52214

	Subject	Repo	Branch	Lines +/-
	Set wikidata's logo specifically for wikidatawiki	operations/mediawiki-config	master	+1 -1

Customize query in gerrit

Related Objects

Mentioned In: rOMWCbee60a0704e5: Set wikidata's logo specifically for wikidatawiki

Event Timeline

• bzimport raised the priority of this task from to Low.Nov 22 2014, 2:00 AM

• bzimport added a project: MediaWiki-extensions-WikimediaIncubator.

• bzimport set Reference to bz52214.

• bzimport added a subscriber: Unknown Object (MLST).

zhuyifei1999 created this task.Jul 29 2013, 11:37 AM

[[:incubator:Wp/zh]]

ebe123_wiki wrote:

Confirmed.

It still displays UNCONFIRMED

ebe123_wiki wrote:

Patch to add exception

Added a "if" for $site Wikidata to give "//upload.wikimedia.org/wikipedia/commons/e/e4/Wikidata-logo-en-135px.png" as an image

Attached:

Wikidata_logo.patch1 KBDownload

The proposed patch is a hack and not an ideal fix.

The actual problem is that in InitialiseSettings.php Wikidata uses both 'wikidata' and 'wikidatawiki' as keys, whereas the Incubator extension depends on 'wikidatawiki' as key (like 'commonswiki' etc). It takes the key from $wmincMultilingualProjects and adds 'wiki' to it.

ebe123_wiki wrote:

I saw that studying the code yesterday.

Bug 67519 has been marked as a duplicate of this bug. ***

Liuxinyu970226 unsubscribed.Dec 25 2014, 7:09 AM

Glaisher updated the task description. (Show Details)Feb 4 2015, 4:23 AM

Glaisher removed a project: Patch-For-Review.

Glaisher set Security to None.

Liuxinyu970226 subscribed.Feb 6 2015, 2:37 AM

Hydriz moved this task from Backlog to In progress on the MediaWiki-extensions-WikimediaIncubator board.Feb 22 2015, 1:17 PM

Liuxinyu970226 unsubscribed.Mar 12 2015, 11:53 PM

Hydriz moved this task from In progress to Backlog on the MediaWiki-extensions-WikimediaIncubator board.Jun 23 2015, 9:30 AM

Restricted Application added a subscriber: Hydriz. · View Herald TranscriptJun 23 2015, 9:30 AM

zhuyifei1999 merged a task: T69519: Fake Wikipedia logo links to Wikidata shown on Incubator.Jun 23 2015, 10:04 AM

zhuyifei1999 added a subscriber: Liuxinyu970226.

zhuyifei1999 removed a subscriber: Liuxinyu970226.

Ebe123 subscribed.Jun 23 2015, 3:56 PM

To be honest that entire function looks like a hack.

Krenair added a project: Wikimedia-Site-requests.Jun 27 2015, 8:01 PM

Restricted Application added a subscriber: Matanya. · View Herald TranscriptJun 27 2015, 8:01 PM

Change 221405 had a related patch set uploaded (by Alex Monk):
Set wikidata's logo specifically for wikidatawiki

https://gerrit.wikimedia.org/r/221405

gerritbot added a project: Patch-For-Review.Jun 27 2015, 8:10 PM

Addshore added a project: Wikidata.Jun 28 2015, 2:52 PM

Addshore moved this task from incoming to monitoring on the Wikidata board.

Change 221405 merged by jenkins-bot:
Set wikidata's logo specifically for wikidatawiki

https://gerrit.wikimedia.org/r/221405

Krenair mentioned this in rOMWCbee60a0704e5: Set wikidata's logo specifically for wikidatawiki.Jun 29 2015, 3:28 PM

Meh. That's a really silly workaround.

Hydriz moved this task from Backlog to Done on the MediaWiki-extensions-WikimediaIncubator board.Jun 29 2015, 3:33 PM

Liuxinyu970226 awarded a token.Jun 28 2017, 6:39 AM