Page MenuHomePhabricator

parser tests should die, when test printed something
Open, MediumPublic

Description

Running php \tests\parserTests.php --quiet

Gives following output:

This is MediaWiki version 1.22alpha (8994a5f).

Notice: LCStore_DB::startWrite: Transaction already in progress (from LocalFile::recordUpload2), performing implicit commit!
[Called from DatabaseBase::begin in \includes\db\Database.php at line 3162] in \includes\debug\Debug.php on line 296

Notice: LocalFile::recordUpload2: No transaction to commit, something got out of sync!
[Called from DatabaseBase::commit in \includes\db\Database.php at line 3214] in \includes\debug\Debug.php on line 296

Notice: WikiPage::doEditContent: Transaction already in progress (from LocalFile::lock), performing implicit commit!
[Called from DatabaseBase::begin in \includes\db\Database.php at line 3162] in \includes\debug\Debug.php on line 296

Passed 985 of 985 tests (100%)... ALL TESTS PASSED!

The notice should trigger a failed test.


Version: 1.22.0
Severity: normal

Details

Reference
bz52274

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:04 AM
bzimport set Reference to bz52274.
bzimport added a subscriber: Unknown Object (MLST).

Change 138740 had a related patch set uploaded by Aaron Schulz:
Improved DB handling in LCStoreDB

https://gerrit.wikimedia.org/r/138740

gerrit 138740 fixed the transcation problems where the printing came from, but the test still not failing, when printing.