Page MenuHomePhabricator

VisualEditor: Following links in image captions that have a large <font size=> value takes over media settings dialog which can't then be closed
Closed, ResolvedPublic

Description

link target takes over media settings dialog

If text has a size specified, e.g <font size=12>, then you cannot edit it in VE at present. The bar that notifies you of this is fixed to standard line height so you can click on links that extend above or beyond this, e.g. <font size=12>text with a [[link]]</font>.

If such a link appears in body text, then clicking it takes you to the link target in the same window (i.e. exactly the same as if you clicked on it in read mode). If you ctrl+click to open in a new window/tab then you get the same behaviour as described for section links in bug 51122.

If such a link appears in an image caption, then ctrl+clicking has the same effect as in the paragraph above/bug 51122. Left clicking does take you to the linked page, but instead of using the main window it uses the media settings dialog's frame (see screenshot). You cannot close this frame - the close button has been replaced by the link target and it doesn't respond to escape.


Version: unspecified
Severity: normal

Attached:

VE_fontsize.png (573×1 px, 364 KB)

Details

Reference
bz52285

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 2:04 AM
bzimport set Reference to bz52285.

Steps to reproduce:

  1. Edit https://en.wikipedia.org/w/index.php?title=User:Thryduulf/sandbox2&oldid=566460073#New_section in VE
  2. Click on the last image and open the media settings dialog
  3. Left click the link above the "can only edit in source" bar.

This happens in Firefox 22 on Linux, I can't test in other browsers/OSes.

Cryptic C62 and en.wp has noted that he can replicate this in Firefox 22 and Chrome 28 running on Windows Vista. Both they and I use the monobook skin.

This has the same root cause as bug 51778, despite the names; merging.

  • This bug has been marked as a duplicate of bug 51778 ***