Page MenuHomePhabricator

Corrected words aren't bolded in suggestions
Closed, ResolvedPublic

Description

Searching for "popular Culatur" yields a suggestion (did you mean:) but doesn't correctly bold the corrected word.

URL: http://en.wikipedia.beta.wmflabs.org/w/index.php?title=Special%3ASearch&profile=default&search=popular+Culatur&fulltext=Search


Version: unspecified
Severity: normal
Whiteboard: Elasticsearch0.90.4
See Also:
https://github.com/elasticsearch/elasticsearch/issues/3442

Details

Reference
bz52286

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:04 AM
bzimport set Reference to bz52286.
bzimport added a subscriber: Unknown Object (MLST).

I have a question out to the elasticsearch mailing lists for this topic.

I have a feature request in with Elasticsearch to make this more efficient but that is in its early stages. If we can live without this for a month we should just wait until that has made it through their process. Otherwise we can accomplish this with either one off space-splitting based code or by making calls to the analyze endpoint in elasticsearch for the original terms and the suggestion, then correlate them.

This is currently waiting on Elasticsearch 0.90.4. Like I mentioned before we can work around not having the feature but it should be available for easy consumption in a month or so.

Change 85206 had a related patch set uploaded by Manybubbles:
Highlight changed words in suggestions.

https://gerrit.wikimedia.org/r/85206

Change 85207 had a related patch set uploaded by Manybubbles:
Tests for highlight changed words in suggestions.

https://gerrit.wikimedia.org/r/85207

Change 85206 merged by jenkins-bot:
Highlight changed words in suggestions.

https://gerrit.wikimedia.org/r/85206

Change 85207 merged by jenkins-bot:
Tests for highlight changed words in suggestions.

https://gerrit.wikimedia.org/r/85207