Page MenuHomePhabricator

the message diff-multi above comparison of several revisions has wrong directionality
Closed, ResolvedPublic

Description

To reproduce:

  1. Go to https://www.wikidata.org/w/index.php?title=Q12060906&diff=56007681&oldid=53789438&uselang=he
  1. Inspect the message above the diff - (7 גרסאות ביניים של 6 משתמשים אינן מוצגות).

Observed: The CSS property direction is "ltr".

Expected: The CSS property direction must be "rtl", because it's Hebrew.

I suspect that it happens because the function that adds this message uses getPageLanguage, while it should use the user language, but I didn't test too deeply.

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:07 AM
bzimport set Reference to bz52321.

Change 79326 had a related patch set uploaded by Amire80:
Add diff-multi to classes with explicit direction

https://gerrit.wikimedia.org/r/79326

Change 79326 merged by jenkins-bot:
Add diff-multi to classes with explicit direction

https://gerrit.wikimedia.org/r/79326

Change 276951 had a related patch set uploaded (by Vaishali Jain):
Change Special:Tags to OOUI

https://gerrit.wikimedia.org/r/276951

Change 335431 had a related patch set uploaded (by Nikssardana):
Short subject line

https://gerrit.wikimedia.org/r/335431

Change 335431 abandoned by Amire80:
Short subject line

Reason:
Looks like a mistake.

https://gerrit.wikimedia.org/r/335431

Change 352321 had a related patch set uploaded (by Jobodobo; owner: Jobodobo):
[mediawiki/extensions/examples@master] This is BUG: T54321

https://gerrit.wikimedia.org/r/352321

Change 376091 had a related patch set uploaded (by Dmaza; owner: Dmaza):
[mediawiki/extensions/AbuseFilter@master] Fix confusing warning message on throtthled filters

https://gerrit.wikimedia.org/r/376091

Change 625946 had a related patch set uploaded (by Sohom Datta; owner: Sohom Datta):
[mediawiki/extensions/ProofreadPage@master] Fix updateButton not getting activated on NumberInput change

https://gerrit.wikimedia.org/r/625946

Change 625946 merged by jenkins-bot:
[mediawiki/extensions/ProofreadPage@master] Fix updateButton not getting activated on NumberInput change

https://gerrit.wikimedia.org/r/625946

Change 740334 had a related patch set uploaded (by Sohom Datta; author: Sohom Datta):

[mediawiki/extensions/ProofreadPage@master] OSD: Prevent original image from getting overwritten by OSD

https://gerrit.wikimedia.org/r/740334

Change 776999 had a related patch set uploaded (by Bking; author: Bking):

[operations/software/spicerack@master] elastic: don't wait for green on first node in cluster

https://gerrit.wikimedia.org/r/776999

Change 783848 had a related patch set uploaded (by Bking; author: Bking):

[operations/puppet@production] Elastic: use major version only for 'config_version'

https://gerrit.wikimedia.org/r/783848

Change 803996 had a related patch set uploaded (by Bking; author: Bking):

[operations/software/elasticsearch/plugins@master] elastic: increment BUILD_VERSION

https://gerrit.wikimedia.org/r/803996

Change 803996 merged by Bking:

[operations/software/elasticsearch/plugins@master] elastic: increment BUILD_VERSION

https://gerrit.wikimedia.org/r/803996