Page MenuHomePhabricator

VisualEditor: When section edit is initiated with an actual page load, VE does not navigate to the section
Closed, ResolvedPublic

Description

When VisEd is activated from a section edit link, the focus of the display normally stays on that section. However, if the user activates from a section edit link while on a diff link (has to be diff of current version), the focus shifts to the top of the page as if the whole page edit link had been pressed.


Version: unspecified
Severity: minor

Details

Reference
bz52566

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 1:54 AM
bzimport set Reference to bz52566.

This is just a special case. The general issue is that VE does not navigate to the section when a section edit is initiated with a fresh page load (it does when it uses the AJAX switch to editing without a page load). For example, https://en.wikipedia.org/w/index.php?title=Earth&veaction=edit&section=6 . It appears in this case because VE (there is a comment to this effect) uses a new page load to start section editing when it's showing the latest diff (to deal with another issue).

This applies any time the user is sent directly to edit a section via VE. For the Growth team's current project, we will allow the user to click "Sign up and edit" (including for sections). This works using the normal signup page, with the returnto and returntoquery parameters. That means we can not do an AJAX switch.

Besides login/signup, there are other (albeit less common) reasons you might want to link directly to a section edit URL.

Change 131415 had a related patch set uploaded by Mattflaschen:
Generate PHP VE edit section with correct parameter, vesection

https://gerrit.wikimedia.org/r/131415

Change 131415 merged by jenkins-bot:
Generate PHP VE edit section with correct parameter, vesection

https://gerrit.wikimedia.org/r/131415