Page MenuHomePhabricator

MediaWiki login for Phabricator produces broken links for Wikimedia profiles with URL encoded characters
Closed, ResolvedPublic

Description

In T541#8313, @liangent wrote:

Note that current links appear double percent-encoded so they're broken for user names containing non-"basic" characters. See https://phabricator.wikimedia.org/p/Fan/ as an example.

The link displayed is https://www.mediawiki.org/w/index.php?title=User%3A%25E8%258C%2583 , which produces a "Bad title" page in mediawiki.org.

The correct URL would be https://www.mediawiki.org/wiki/User:%E8%8C%83

Revisions and Commits

Event Timeline

Qgil raised the priority of this task from to Needs Triage.
Qgil updated the task description. (Show Details)
Qgil added a project: Phabricator.
Qgil changed Security from none to None.
Qgil added subscribers: Qgil, mmodell, liangent.

@mmodell, do you think it is feasible to fix this before Day 1?

If we got a real user hitting this problem even before announcing that Phabricator registration is open, there is a chance that we will get more cases before and right after Day 1.

Aklapper renamed this task from MediaWiki login for Phabricator produces broken links for Wikimedia profiles with non-Latin characters to MediaWiki login for Phabricator produces broken links for Wikimedia profiles with URL encoded characters.Oct 6 2014, 11:46 AM
Aklapper triaged this task as Medium priority.

@Aklapper: it actually required more calls to urldecode not less ;)

@everyone: review please...

This double encoding issue seems to also effect the links to OAuth accounts on https://phabricator.wikimedia.org/settings/panel/external/

In T547#8678, @bd808 wrote:

This double encoding issue seems to also effect the links to OAuth accounts on https://phabricator.wikimedia.org/settings/panel/external/

It appears URLs are stored in some double encoded form in Phab. We should make stored URLs correct, not just fix (=urldecode) them on display.

This is "Closed,Resolved" but it happened to me when I linked accounts; I filed T574 before spotting this bug.

mmodell added a commit: Unknown Object (Diffusion Commit).Apr 8 2015, 4:29 PM