Page MenuHomePhabricator
Create Task
Maniphest T54711

Echo: Help tooltip in preferences is not accessible
Closed, ResolvedPublic
Actions

Description

The help tooltips in the preferences, used by the Echo extension are not accessible.

These are being generated by HTMLCheckMatrix in includes/htmlform/fields/HTMLCheckMatrix.php in mediawiki-core. We need to make this accessible. Possibly by using aria-labelledby, see https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/ARIA_Techniques/Using_the_aria-labelledby_attribute and https://www.w3.org/TR/wai-aria-1.1/#aria-labelledby

Details

Reference
bz52711
SubjectRepoBranchLines +/-
Fix tooltip accessibility for screen readersmediawiki/coremaster+1 -0
Customize query in gerrit

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:04 AM
• bzimport added projects: MediaWiki-Core-Preferences, Accessibility.
• bzimport set Reference to bz52711.
• bzimport added a subscriber: Unknown Object (MLST).
TheDJ created this task.Aug 10 2013, 9:45 PM
• werdna unsubscribed.Dec 10 2014, 5:27 PM
Danny_B moved this task from Unsorted to Tooltip on the Accessibility board.Jan 22 2016, 9:18 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 22 2016, 9:18 PM
• Prtksxna renamed this task from Help tooltip in preferences is not accessible to Echo: Help tooltip in preferences is not accessible.Nov 8 2017, 4:59 AM
• Prtksxna updated the task description. (Show Details)
• Prtksxna added a project: Google-Code-in-2017.
• Prtksxna subscribed.

I'd like to mentor this during Google-Code-in-2017.

Florian moved this task from Proposed tasks to Imported in GCI Site on the Google-Code-in-2017 board.Nov 14 2017, 7:14 PM
Florian subscribed.

Imported as: https://codein.withgoogle.com/dashboard/tasks/5085632210665472/

Aklapper updated the task description. (Show Details)Nov 20 2017, 1:30 PM
divadsn claimed this task.Dec 14 2017, 8:18 AM
divadsn added a comment.EditedDec 14 2017, 8:38 AM

Gonna look later on my PC at home if my changes work, after that I will upload my patchset :)

divadsn added a comment.Dec 14 2017, 8:39 AM
This comment was removed by divadsn.
divadsn added a comment.Dec 14 2017, 8:51 AM

So we need an additional attribute in HTMLCheckMatrix for aria-labelledby so the Echo extension can make a use of those for accessibility?

• Prtksxna added a comment.Dec 15 2017, 7:26 AM
In T54711#3836740, @divadsn wrote:

So we need an additional attribute in HTMLCheckMatrix for aria-labelledby so the Echo extension can make a use of those for accessibility?

Yep, that is correct.

divadsn added a comment.Dec 16 2017, 1:39 AM

I've got an even better idea, as I noticed that tipsy.js is replacing title with original-title, I just renamed original-title to aria-label, so we've got it fixed for every tooltip :)

gerritbot subscribed.Dec 16 2017, 1:44 AM

Change 398611 had a related patch set uploaded (by Divadsn; owner: Divadsn):
[mediawiki/core@master] Fix tooltip accessibility for screen readers

https://gerrit.wikimedia.org/r/398611

gerritbot added a project: Patch-For-Review.Dec 16 2017, 1:44 AM
Florian closed this task as Resolved.Dec 16 2017, 2:53 PM
gerritbot added a comment.Dec 16 2017, 2:59 PM

Change 398611 merged by jenkins-bot:
[mediawiki/core@master] Fix tooltip accessibility for screen readers

https://gerrit.wikimedia.org/r/398611

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)).Dec 16 2017, 3:00 PM
Volker_E subscribed.Dec 18 2017, 9:40 PM

@divadsn Thanks, very nice improvement!

Volker_E awarded a token.Dec 18 2017, 9:40 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL