Page MenuHomePhabricator

Preserve positional template parameters even if a nested template contains a '='
Closed, ResolvedPublic

Description

Derived from bug 51961, comment 1: Positional parameters with an '=' in them are converted to named parameters, even if the '=' is safely embedded inside a nested transclusion.

Minimal test case:

{{echo|{{echo|1=bar}}}}

To fix this, we should probably tokenize the value with appropriate flags and look at the remaining string content instead of the entire string.


Version: unspecified
Severity: normal

Details

Reference
bz52824

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 2:13 AM
bzimport set Reference to bz52824.

Change 79836 had a related patch set uploaded by Subramanya Sastry:
WIP: (Bug 52824) Improved handling of '=' char in tpl-param values

https://gerrit.wikimedia.org/r/79836

Change 79836 merged by jenkins-bot:
(Bug 52824) Improved handling of '=' char in tpl-param values

https://gerrit.wikimedia.org/r/79836

Now deployed to production. Verified fixed on an old id of the airport pages. Also verified the fix on https://fr.wikipedia.org/wiki/Robert_Soucy?veaction=edit as per bug 51961, comment 1.