Page MenuHomePhabricator

Category contents is not shown if the preview is at the bottom
Closed, ResolvedPublic

Description

Author: bugzilla-wikimedia-org

Description:

TOP

$wgOut->addHTML( '<div id="wikiPreview">' );
if ( 'preview' == $formtype) {
$previewOutput = $this->getPreviewText( $isConflict, $isCssJsSubpage );
if ( $wgUser->getOption('previewontop' ) ) {

		$wgOut->addHTML( $previewOutput );
		if($this->mTitle->getNamespace() == NS_CATEGORY) {
			$this->mArticle->closeShowCategory();
		}				
		$wgOut->addHTML( "<br style=\"clear:both;\" />\n" );

}
}

$wgOut->addHTML( '</div>' );

BOTTOM

if ( $formtype == 'preview' && !$wgUser->getOption( 'previewontop' ) ) {
$wgOut->addHTML( '<div id="wikiPreview">' . $previewOutput . '</div>' );

}

I.e. this is missing:
if($this->mTitle->getNamespace() == NS_CATEGORY) {

		$this->mArticle->closeShowCategory();

}

Also, if it's at the bottom. "<div id="wikiPreview"></div>" is still output at the top, resulting
in two divs with the same id. (I don't know if this causes a problem for scripting or not but it's
still unnecessary.)

(I also noticed openShowCategory() not called - although it is currently blank, if anything was
added to it then the preview would be different to the action view.)


Version: 1.5.x
Severity: minor

Details

Reference
bz3487

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 8:49 PM
bzimport set Reference to bz3487.
bzimport added a subscriber: Unknown Object (MLST).
brion added a comment.Nov 3 2005, 10:44 PM

Fixed in HEAD for 1.6.