Page MenuHomePhabricator

VisualEditor: Switch to use MediaWiki's built-in messages for post-edit notifications (and add to them so we cover all three cases)
Closed, ResolvedPublic

Description

Author: swalling

Description:
Screenshot at 1024x768

Very happy to see that VE is now using the same post-edit styling as wikitext! This is a big win for usability, since it is fixed position and so on.

I did find one suboptimal fact though... Since the text of the message includes the page title, it is very variable width, depending on the page title length and the browser width.

One of the UX goals for this notification is to have new users notice it, but for it to eventually fade out of your attention as you become used to it. Since the page title produces very different widths as you edit different pages, this calls a lot more attention to the notification even if you've edit thousands of times.

My recommendation would be to match what's in the wikitext version, "Your edit was saved." since we A/B tested it and we know it meets the goals I mentioned above. Another good solution is simply removing the page title, so that the VE version says, "Your changes have been saved." That seems functionally the same, though I think using edit is good for consistency with the tab names etc.


Version: unspecified
Severity: minor

Attached:

Details

Reference
bz52871

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 1:47 AM
bzimport set Reference to bz52871.

Current VE messages:

"visualeditor-notification-created": "\"$1\" has been created.",
"visualeditor-notification-restored": "\"$1\" has been restored.",
"visualeditor-notification-saved": "Your changes to \"$1\" have been saved.",

Current MW core message:

'postedit-confirmation'            => 'Your edit was saved.',

We should:

  1. Expand MW core to cater to all three states (create, restore, save):
  • Create: "The page has been created."
  • Restore: "The page has been restored."
  • Saved: "Your edit was saved."
  1. Not use different messages in VE – instead, use the core ones.

Rather than create two bugs, let's just use this one?

Change 127480 had a related patch set uploaded by Alex Monk:
Expand core post edit functionality to match VE

https://gerrit.wikimedia.org/r/127480

Now just needs VE to use the same function.

Change 127480 merged by jenkins-bot:
Expand core post edit functionality to match VE

https://gerrit.wikimedia.org/r/127480

Change 130968 had a related patch set uploaded by Alex Monk:
Switch to use MediaWiki's built-in messages for post-edit notifications

https://gerrit.wikimedia.org/r/130968

Change 130968 merged by jenkins-bot:
Switch to use MediaWiki's built-in messages for post-edit notifications

https://gerrit.wikimedia.org/r/130968