Page MenuHomePhabricator
Create Task
Maniphest T54919

Data about oldest revisions of edit filters from (some?) WMF wikis is not available in the logs
Closed, ResolvedPublic
Actions

Description

We are not able to get logs for any of the 131 oldest AbuseFilter modifications on Portuguese Wikipedia:
https://pt.wikipedia.org/wiki/Special:AbuseFilter/history?offset=20090704151453&limit=131&uselang=en
either by the API query
https://pt.wikipedia.org/w/api.php?action=query&list=logevents&format=jsonfm&leprop=ids|title|type|user|userid|timestamp|comment|parsedcomment|details|tags&leaction=abusefilter/modify&ledir=newer&lelimit=1
or by the UI:
https://pt.wikipedia.org/wiki/Special:Log/abusefilter?dir=prev&uselang=en

Compare with
https://en.wikipedia.org/wiki/Special:Log/abusefilter?dir=prev
where the oldest log is from 17 March 2009, and corresponds to the oldest change listed in the AbuseFilter's history:
https://en.wikipedia.org/w/index.php?title=Special:AbuseFilter/history/&dir=prev
(I wasn't able to check the analogous API query for enwiki, because of T54918)

Would it be possible to run some maintenance script to add the missing changes to the logs of the affected WMF wikis? This would allow us to get this information from Wikipedias using the MediaWiki API.

Version: wmf-deployment
Severity: minor

Details

Reference
bz52919
ProjectBranchLines +/-Subject
mediawiki/extensions/AbuseFiltermaster+1 -1No longer call removed SpecialPage::getLocalPageForName
mediawiki/extensions/AbuseFiltermaster+2 -2Fix addMissingLoggingEntries maintenance script handling of newlines
Customize query in gerrit

Related Objects

Event Timeline

• bzimport raised the priority of this task from to Low.Nov 22 2014, 1:50 AM
• bzimport added a project: WMF-General-or-Unknown.
• bzimport set Reference to bz52919.
He7d3r created this task.Aug 16 2013, 12:27 PM
Reedy added a comment.Aug 16 2013, 12:33 PM

(In reply to comment #0)

Would it be possible to run some maintenance script to add the missing
changes
to the logs of the affected WMF wikis? This would allow us to get this
information from Wikipedias using the MediaWiki API.

One would have to exist first...

He7d3r added a comment.Aug 16 2013, 12:39 PM

(In reply to comment #0)

Compare with
https://en.wikipedia.org/wiki/Special:Log/abusefilter?dir=prev
where the oldest log is from 17 March 2009, and corresponds to the oldest
change listed in the AbuseFilter's history:
https://en.wikipedia.org/w/index.php?title=Special:AbuseFilter/history/
&dir=prev
(I wasn't able to check the analogous API query for enwiki, because of bug

Hmm... Actually, these 1108 entries
https://en.wikipedia.org/w/index.php?title=Special:AbuseFilter/history&offset=20090703235800&limit=1108
are missing from enwiki's log:
https://en.wikipedia.org/wiki/Special:Log/abusefilter?dir=prev

Krenair added a comment.Sep 21 2013, 6:59 PM

Caused by r48501 deployed around 2009-03-17, fixed from deployment of r52734 on 2009-07-03 (this bug is about fixing up the entries made in between)

gerritbot added a comment.Sep 23 2013, 2:41 PM

Change 85675 had a related patch set uploaded by Alex Monk:
Add maintenance script to restore missing log entries for each filter history entry

https://gerrit.wikimedia.org/r/85675

He7d3r added a project: MediaWiki-Maintenance-system.Jan 12 2015, 7:02 PM
He7d3r set Security to None.
• MZMcBride added a subscriber: • MZMcBride.Apr 7 2015, 7:20 PM
Krenair added a parent task: T31782: [DO NOT USE] Maintenance scripts waiting to be run on Wikimedia wikis (tracking) [superseded by #WMF-maintenance-script-run].Aug 11 2015, 7:55 PM

(Merged by Aaron, thanks!)
I'll run this next week.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 11 2015, 7:57 PM
Krenair edited projects, added AbuseFilter; removed Patch-For-Review.Aug 11 2015, 7:57 PM
Restricted Application added a subscriber: Luke081515. · View Herald TranscriptAug 11 2015, 7:57 PM
Krenair added a comment.Aug 22 2015, 10:25 PM

I've encountered some issues with the script and will need to make a small change

gerritbot added a subscriber: gerritbot.Aug 22 2015, 10:29 PM

Change 233174 had a related patch set uploaded (by Alex Monk):
Fix addMissingLoggingEntries maintenance script handling of newlines

https://gerrit.wikimedia.org/r/233174

gerritbot added a project: Patch-For-Review.Aug 22 2015, 10:29 PM
gerritbot added a comment.Aug 22 2015, 10:45 PM

Change 233174 merged by jenkins-bot:
Fix addMissingLoggingEntries maintenance script handling of newlines

https://gerrit.wikimedia.org/r/233174

Diffusion mentioned this in rMEXT0fb012d01ab5: Updated mediawiki/extensions Project: mediawiki/extensions/AbuseFilter….Aug 22 2015, 10:45 PM
Krenair mentioned this in rEABFe3db4db83e42: Fix addMissingLoggingEntries maintenance script handling of newlines.Aug 22 2015, 10:47 PM
gerritbot added a comment.Aug 22 2015, 11:03 PM

Change 233176 had a related patch set uploaded (by Alex Monk):
No longer call removed SpecialPage::getLocalPageForName

https://gerrit.wikimedia.org/r/233176

gerritbot added a comment.Aug 22 2015, 11:29 PM

Change 233176 merged by jenkins-bot:
No longer call removed SpecialPage::getLocalPageForName

https://gerrit.wikimedia.org/r/233176

Diffusion mentioned this in rMEXT29332c8798bb: Updated mediawiki/extensions Project: mediawiki/extensions/AbuseFilter….Aug 22 2015, 11:29 PM
Krenair mentioned this in rEABFd010f3c0c9ca: No longer call removed SpecialPage::getLocalPageForName.Aug 22 2015, 11:29 PM
Krenair closed this task as Resolved.Aug 22 2015, 11:36 PM

alswiki: Inserted 181 rows.
arwiki: Inserted 67 rows.
commonswiki: Inserted 149 rows.
dewiki: Inserted 132 rows.
elwiki: Inserted 171 rows.
enwiki: Inserted 2292 rows.
enwikinews: Inserted 20 rows.
enwikiquote: Inserted 48 rows.
enwikisource: Inserted 50 rows.
fiwiki: Inserted 90 rows.
hewiki: Inserted 209 rows.
hiwiki: Inserted 1 rows.
ltwiki: Inserted 30 rows.
mediawikiwiki: Inserted 5 rows.
metawiki: Inserted 115 rows.
nlwiki: Inserted 168 rows.
nlwikibooks: Inserted 10 rows.
plwiki: Inserted 99 rows.
ptwiki: Inserted 130 rows.
ruwiki: Inserted 327 rows.
simplewiki: Inserted 1 rows.
svwiki: Inserted 87 rows.
testwiki: Inserted 274 rows.
ukwiki: Inserted 17 rows.
usabilitywiki: Inserted 7 rows.
zh_yuewiki: Inserted 80 rows.
zhwiki: Inserted 497 rows.

• Forrestbot added a project: WMF-deploy-2015-08-25_(1.26wmf20).Aug 23 2015, 1:01 AM
He7d3r updated the task description. (Show Details)Aug 23 2015, 2:17 PM
He7d3r mentioned this in T54920: AbuseFilter API should provide details about old revisions of filters.Nov 28 2016, 11:20 AM
MarcoAurelio added a project: Wikimedia-maintenance-script-run.Mar 15 2017, 12:36 PM
MarcoAurelio removed a parent task: T31782: [DO NOT USE] Maintenance scripts waiting to be run on Wikimedia wikis (tracking) [superseded by #WMF-maintenance-script-run].Mar 15 2017, 12:48 PM
Stashbot added a subscriber: Stashbot.Feb 12 2018, 6:48 PM

Mentioned in SAL (#wikimedia-releng) [2018-02-12T18:48:22Z] <Hauskatze> Restoring first missing log entries on Beta refs. T54919

Daimona mentioned this in T228655: Dry-run, then actually run fixOldLogEntries for AbuseFilter.Aug 11 2019, 3:37 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL