Page MenuHomePhabricator

Use data.* instead of manual JSON attribute loading / saving throughout the DOM postprocessor
Closed, DuplicatePublic

Description

We have moved data-parsoid to data.parsoid on the DOM and save that data at the end of DOM postprocessing. Other attributes like data-mw are currently handled manually.

It would probably be both faster and more convenient to use data.* for those attributes as well. The necessary support for loading and saving them is mostly implemented in loadDataAttrib (missing: loadDataAttribs) and saveDataAttribs. With the exception of data-parsoid, we should only load data attributes that are actually defined by default.


Version: unspecified
Severity: enhancement

Details

Reference
bz53109

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 2:03 AM
bzimport set Reference to bz53109.

Change 159254 had a related patch set uploaded by Arlolra:
Move data-mw away from manual JSON attr loading

https://gerrit.wikimedia.org/r/159254

Change 159254 had a related patch set uploaded by Arlolra:
(Bug 53109) Move data-mw away from manual JSON attr loading

https://gerrit.wikimedia.org/r/159254

Change 159254 merged by jenkins-bot:
(Bug 53109) Move data-mw away from manual json attr loading

https://gerrit.wikimedia.org/r/159254

Aren't there other data-* properties left to do?

I guess I was thinking about

data-parsoid-diff, data-parsoid-serialize

but I those are just serialization things.