VisualEditor: Undo/redo doesn't go through dm.Surface.change() code path
Closed, ResolvedPublic


dm.Surface.undo() and .redo() just call documentModel.rollback() / .commit() directly, without going through all the other stuff in .change() . Presumably this other stuff is useful, so we should figure out if bypassing it causes bugs.

Version: unspecified
Severity: normal


Catrope created this task.Aug 22 2013, 5:14 PM

In theory Surface.change() should also have a corresponding Surface.unchange() method (or a 'reversed' parameter).

Change 88728 had a related patch set uploaded by Catrope:
Implement and redo() in terms of change()

Change 88728 merged by jenkins-bot:
Implement and redo() in terms of change()

Add Comment