Page MenuHomePhabricator

VisualEditor: When reversing a transaction, create a new transaction rather than reusing the old one
Closed, ResolvedPublic

Description

Rather than passing around boolean parameters called 'reversed' all over the place, we should use each transaction only once, and implement a function that creates a new transaction that's the reverse of an existing transaction.


Version: unspecified
Severity: enhancement

Details

Reference
bz53225

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:10 AM
bzimport set Reference to bz53225.

But note that the code currently uses the fact that the commit and rollback transaction are the same in order to update the 'applied' field. So the rollback transaction should still contain a pointer to the original transaction, and when it is committed both should be marked with 'applied=false' (which indicates that we can skip over these entries in the completeHistory).

This was done ages ago in I3050c5430be4a12510f22e20853560b92acebb67