Page MenuHomePhabricator

diff=prev of first revision of a page says "No difference"; should either show diff of full page or no message
Open, LowPublic

Description

diff=prev of first revision of a page acts funny: it claims there is "No difference" between the null and the first version of a page. It acts this way since I458fb688.

Example: https://pl.wikipedia.org/w/index.php?title=Wikipedia:Powiadomienia/Podzi%C4%99kowania&oldid=37320666&diff=prev&uselang=en

It should either show a diff of full page contents against a blank string, or show blank space with no additional message.

Such "diffs" are normally not accessible from the interface, but the Thanks extension can link to them if a user is thanked for such edit.


Version: 1.22.0
Severity: normal
URL: https://pl.wikipedia.org/w/index.php?title=Wikipedia:Powiadomienia/Podzi%C4%99kowania&oldid=37320666&diff=prev&uselang=en

Details

Reference
bz53299

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 1:46 AM
bzimport added a project: MediaWiki-Page-Diffs.
bzimport set Reference to bz53299.
bzimport added a subscriber: Unknown Object (MLST).

A diff link between the current version as oldid and diff=next is showing the one version on both side and the "no difference" in the middle, that is also not a behaviour.

The empty string came from a "Short-circuit" where the oldRev is checked against false (and if the revids between old and new the same).

No idea at the moment how to handle this rare case.

WTM added a subscriber: WTM.Aug 1 2015, 1:19 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 1 2015, 1:19 PM
Aklapper renamed this task from diff=prev of first revision of a page acts funny, claims "No difference" to diff=prev of first revision of a page says "No difference"; should either show diff of full page or no message.Aug 11 2019, 9:30 PM
Aklapper lowered the priority of this task from Medium to Low.
Aklapper removed a subscriber: wikibugs-l-list.