Page MenuHomePhabricator

Add a confirmation dialog before closing the window when editing Wikidata
Open, LowPublic

Description

When editing Wikidata, in case of accidentally closing the browser window, no confirmation is asked and all changes that were not saved are lost.

Steps to reproduce:

  • Start editing an item, for example in the sandbox
  • Force closing the window (Ctrl+W, Alt+F4)
  • No confirmation dialog is shown, the window is closed immediately

On the contrary, when editing Wikipedia with the visual editor, or any page using the regular Mediawiki wikicode editor, the usual browser window ("This page is asking you to confirm that you want to leave - data you have entered may not be saved. Stay on the page / Leave page") appears.

Suggested by user:Verdi p on Contact the Development team

Details

Reference
bz53478

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 1:58 AM
bzimport set Reference to bz53478.
bzimport added a subscriber: Unknown Object (MLST).

Sorry, I don't consider this relevant.

It's nice to have this feature (which, if the setting isn't removed along with so many other recently removed settings, can be disabled by the user) on wikitext pages since you can loose hours of work.

In Wikidata you will never loose more than a few seconds of work.

If we introduce this it will be annoying for many users and most probably needs an other setting separated from the users "wpuseeditwarning" setting. I don't think this is worth the trouble.

I think this should be closed for now (or at least set to "low") and maybe reopened if the Wikidata editing interface is changed in a way you can loose more than a few seconds of work.

Lydia_Pintscher removed a subscriber: Unknown Object (MLST).
Lydia_Pintscher removed a subscriber: Unknown Object (MLST).
Jonas raised the priority of this task from Medium to Needs Triage.Jul 31 2015, 11:32 AM
Jonas set Security to None.

As per Thiemo: For now let's not do it but if there is more demand we will reconsider.

Do we have a rule regarding merging new tasks into old tasks?

Here I created T248859 based on a recent request from a user, and it got merged to this one, that has almost no description and contains quite outdated comments. I think it would have been more useful to keep the task with more description, or at least to copy the description to the old task. In the end, we end up with the good description being quite invisible.

It's not the first time that it happens with tasks that you merge @Bugreporter. What do you think?

Tacsipacsi renamed this task from Warn users for unsaved data to Add a confirmation dialog before closing the window when editing Wikidata.Jun 6 2020, 4:32 PM
Tacsipacsi updated the task description. (Show Details)
Tacsipacsi subscribed.

@Lea_Lacroix_WMDE I think merging into the older item is usually a good idea (potentially more comments, more subscribers, more links from outside of Phabricator etc.), but the descriptions and titles should be merged/updated as necessary. By the way, I don’t consider the comments outdated—the time spent with one edit didn’t get considerably longer over the years, although some typo fixes in the label can take several hours if it’s hard to find out what the right version is, so I think it’s a useful feature for Wikidata as well.

Lydia_Pintscher raised the priority of this task from Lowest to Low.Jun 6 2020, 4:34 PM
Lydia_Pintscher moved this task from monitoring to ready to go on the Wikidata board.