Page MenuHomePhabricator

Echo: Fix "Invalid CSS property value" for text-shadow
Closed, ResolvedPublic

Description

Composition is current (top left), space fixed (bottom right), value fixed (top right)

The text-shadow for mw-echo-notifications-badge has an invalid value, as a result the style is ignored and not rendered.

The value is invalid because it contains a non-breaking space, which is not allowed.

The value is also missing a leading 0 (it should have 3 dimension values, 2 works (as demonstrated in the screenshot) but is probably not what you want).

See attached screenshot for:

  • Current value, and rendering thereof (no shadow because value is invalid)
  • What it would look like with the space fixed (0 1px shadow)
  • What it would look like with the value fixed (0 0 1px shadow)

Version: unspecified
Severity: normal

Attached:

Screen_Shot_2013-08-28_at_10.47.25_AM.png (1×2 px, 769 KB)

Details

Reference
bz53490

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 1:59 AM
bzimport added a project: Notifications.
bzimport set Reference to bz53490.
bzimport added a subscriber: Unknown Object (MLST).

Change 81529 had a related patch set uploaded by Krinkle:
badge: Fix invalid CSS value for text-shadow

https://gerrit.wikimedia.org/r/81529

Change 81502 had a related patch set uploaded by Matmarex:
ext.echo.badge: Remove defunct CSS rule

https://gerrit.wikimedia.org/r/81502

Change 81502 merged by jenkins-bot:
ext.echo.badge: Remove defunct CSS rule

https://gerrit.wikimedia.org/r/81502

This was fixed by my patch (which I submitted completely independently, I swear).

Change 81529 abandoned by Matmarex:
badge: Fix invalid CSS value for text-shadow

Reason:
This was fixed by my patch https://gerrit.wikimedia.org/r/81502 (which I submitted completely independently, I swear).

https://gerrit.wikimedia.org/r/81529