Page MenuHomePhabricator

[Beta] Clicking the hamburger icon sends user to Special:MobileMenu instead of just opening the menu on current page
Closed, ResolvedPublic

Description

Author: swalling

Description:
mobile Safari

I am intermittently getting this error in Beta, where the mobile site directs me to en.m.wikipedia.org/wiki/Special:MobileMenu#mw-mf-page-left when clicking the hamburger, instead of just opening the menu on current page. Maryana said she's seen this as well.


Version: unspecified
Severity: enhancement

Attached:

photo.jpg (1×640 px, 49 KB)

Details

Reference
bz53511

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 2:01 AM
bzimport set Reference to bz53511.
bzimport added a subscriber: Unknown Object (MLST).

Probably need to load the JS at the top of the page.

Just to confirm Steven this is only beta or do you see this on various modes? Is this a new thing or has this always been the case?

There are various things that could be happening - the most likely as Ryan suggests is that the JavaScript hasn't yet run. Alas there is not much we can do about this aside from making the page load as fast as possible as the element needs to exist before it is binded to the navigation. Another is that there is a JavaScript error somewhere preventing it from loading and a third option is that there were some experiments with touch events which might not be triggering for some reason.

Marking as an enhancement - although this is annoying - this could be seen as a useful feature on slow connections. The other option would be to disable the button until JavaScript has loaded which I think is not such a good experience.

I personally think we should focus on making the page load as fast as possible which will also make this problem go away.

swalling wrote:

(In reply to comment #2)

Just to confirm Steven this is only beta or do you see this on various modes?
Is this a new thing or has this always been the case?

There are various things that could be happening - the most likely as Ryan
suggests is that the JavaScript hasn't yet run. Alas there is not much we can
do about this aside from making the page load as fast as possible as the
element needs to exist before it is binded to the navigation. Another is that
there is a JavaScript error somewhere preventing it from loading and a third
option is that there were some experiments with touch events which might not
be
triggering for some reason.

Marking as an enhancement - although this is annoying - this could be seen
as a
useful feature on slow connections. The other option would be to disable the
button until JavaScript has loaded which I think is not such a good
experience.

I personally think we should focus on making the page load as fast as
possible
which will also make this problem go away.

Yes, this problem is likely the loading issue, because it only tends to happen on the first couple mobile pageviews. I have got the error only on Beta, but wouldn't be surprised if it showed up on stable too.

Change 83207 had a related patch set uploaded by JGonera:
Make navigation.js load at the top

https://gerrit.wikimedia.org/r/83207

Change 83561 had a related patch set uploaded by JGonera:
Introduce header-loaded event

https://gerrit.wikimedia.org/r/83561

Change 83561 merged by jenkins-bot:
Introduce header-loaded event

https://gerrit.wikimedia.org/r/83561

Change 83207 merged by jenkins-bot:
Make navigation.js load at the top

https://gerrit.wikimedia.org/r/83207

Closing this since above patch is merged and this is the best we can do for the time being.