Page MenuHomePhabricator

CentralNotice saving incredibly slow/timing out
Closed, ResolvedPublic

Description

This has been a bit of an issue for at least a couple months now but feels like it's getting worse. Every time I save a change on a banner (whether I'm adding a message or not) it takes an incredibly long amount of time (Upwards of minutes at times) and sometimes times out completely. For example my most recent save ( https://meta.wikimedia.org/w/index.php?title=MediaWiki:Centralnotice-template-PrivacyPolicyDiscussion_Standard1&diff=prev&oldid=5769136 ) ended in a time out and the error pasted below. As far as I can tell the edit DID save though when I went back to check.

Request: POST http://meta.wikimedia.org/wiki/Special:CentralNoticeBanners/edit/PrivacyPolicyDiscussion_Standard1, from 208.80.154.77 via cp1002.eqiad.wmnet (squid/2.7.STABLE9) to 10.64.0.130 (10.64.0.130)
Error: ERR_READ_TIMEOUT, errno [No Error] at Mon, 02 Sep 2013 07:25:31 GMT


Version: unspecified
Severity: normal

Details

Reference
bz53674

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 2:12 AM
bzimport set Reference to bz53674.

yeah, just had another one that took 2 minutes or so to 'save' despite the fact that the save itself seemed to happen essentially right away according to the contributions. I'm assuming it's trying to update something else in the background.

Sorry for comment spam. To help narrow down: If adding text a variable that save doesn't take long at all (though it does seem to reload without the text you just saved, making you think it didn't save, but if you refresh you'll see it).

This is a common occurrence for me too, although I can't recall ever having an actual timeout. Comment 1 rings true, I am often able to view changes to a banner on the live sites (with ?banner=xyz) well before CentralNotice has finished 'saving'.

mwalker wrote:

It's running a translation job in the background... I'll need to move it somewhere else I think.

mwalker wrote:

https://gerrit.wikimedia.org/r/#/c/79184/ will likely fix the symptom but not the problem. (I added a new configuration variable that will allow us to run the translation job async to saving -- but it means that messages will not be immediately available to translate.)

(In reply to comment #5)

https://gerrit.wikimedia.org/r/#/c/79184/

Patch got merged. Retesting highly welcome.

mwalker wrote:

We're deploying later today.

(In reply to comment #7)

We're deploying later today.

James / Matt: Is this still an issue or can this be closed as RESOLVED FIXED?

Change 84676 had a related patch set uploaded by Mwalker:
Cache Banner Message Field Definitions

https://gerrit.wikimedia.org/r/84676

mwalker wrote:

I wish it was resolved :)

We're trying many different things.

Change 84676 merged by Adamw:
Cache Banner Message Field Definitions

https://gerrit.wikimedia.org/r/84676