Page MenuHomePhabricator

Enhanced recent changes: Arrow to show collapsed changes doesn't respond to space
Closed, ResolvedPublic

Description

Followup to bug 17616.
Browser: Firefox 25.

Steps to reproduce:

  1. Go to [Special:RecentChanges] (which has some items collapsed)
  2. Focus an arrow to show collapsed changes
  3. Press the space bar

What happes:
Nothing.

What I expected:
One of the following alternatives:

  1. like a link - like when nothing is focused, the browser scrolls down a page
  2. like a button - like when I hit enter, items are either shown or collapsed

In Chrome 28 this bug does not exist (scrolls down a page).


Version: 1.22.0
Severity: minor

Details

Reference
bz53797

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 1:53 AM
bzimport set Reference to bz53797.

Personally I lean towards making space trigger the toggle action... any opinions on that?

@Marius: That's consistent with toggling the "portals" in the menu on the left, so I agree.

Change 83226 had a related patch set uploaded by Hoo man:
Allow toggling elements with space

https://gerrit.wikimedia.org/r/83226

Change 83226 merged by jenkins-bot:
Allow toggling elements with space

https://gerrit.wikimedia.org/r/83226