Page MenuHomePhabricator
Create Task
Maniphest T55912

No fallback implemented for mb_strtolower (if mb extension is not enabled)
Closed, ResolvedPublic
Actions

Description

Author: Bryan.TongMinh

Description:
SVG.php uses mb_strtolower, but this function is not defined in Fallback.php, causing unit tests to fail if the mb extension is not enabled.

Version: 1.22.0
Severity: normal

Details

Reference
bz53912
Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Replace mb_strtolower with strtolowermediawiki/coremaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:01 AM
• bzimport added a project: MediaWiki-General.
• bzimport set Reference to bz53912.
• bzimport added a subscriber: Unknown Object (MLST).
• bzimport created this task.Sep 8 2013, 3:24 PM
matmarex added a comment.Sep 8 2013, 3:29 PM

I think an alternate implementation exists in the form of Language#lc. It'd just have to be hooked up in appropriate places.

• bzimport added a comment.Sep 8 2013, 3:31 PM

Bryan.TongMinh wrote:

Or the implementation has to move to Fallback and Language could call mb_strtolower unconditionally

gerritbot subscribed.Mar 25 2015, 8:56 AM

Change 199584 had a related patch set uploaded (by Nikerabbit):
Replace mb_strtolower with strtolower

https://gerrit.wikimedia.org/r/199584

gerritbot added a project: Patch-For-Review.Mar 25 2015, 8:56 AM
Nemo_bis subscribed.Mar 25 2015, 9:01 AM
matmarex unsubscribed.Mar 25 2015, 11:56 AM
gerritbot added a comment.Mar 26 2015, 2:37 AM

Change 199584 merged by jenkins-bot:
Replace mb_strtolower with strtolower

https://gerrit.wikimedia.org/r/199584

Nikerabbit mentioned this in rMW82e9fbc1749d: Replace mb_strtolower with strtolower.Mar 26 2015, 2:37 AM
Nikerabbit subscribed.Mar 26 2015, 6:36 AM

Last instance in core was removed, so this bug could be closed now.

Nemo_bis closed this task as Resolved.Mar 26 2015, 8:26 AM
Nemo_bis assigned this task to Nikerabbit.
Nemo_bis added a project: MW-1.25-release.
Nemo_bis set Security to None.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits