Page MenuHomePhabricator
Create Task
Maniphest T56029

VisualEditor: Provide support for BLP edit notices on enwiki
Closed, ResolvedPublic40 Estimated Story Points
Actions

Description

For BLP's and disambiguation pages on the English Wikipedia, an extra edit notice is provided through the https://en.wikipedia.org/wiki/Wikipedia:EDITINTRO system using Extension:InputBox and some code in MediaWiki:Common.js. VisualEditor does not work with Extension:InputBox, so the edit notice is not displayed.

This hack is being used in several Wikimedia wikis besides the English Wikipedia:

See also Template:BLP editintro (Q10566946) and Template:Disambig editintro (Q14400704) for more of the potentially affected wikis.

Version: unspecified
Severity: normal

Details

Reference
bz54029
SubjectRepoBranchLines +/-
Support '&editintro=…' etc. on back/forward and VE/NWE switchmediawiki/extensions/VisualEditormaster+10 -2
Support '&editintro=…' etc. on subsequent loads via page tabsmediawiki/extensions/VisualEditormaster+18 -21
Fix '&editintro=…' not working on Vector with some settingsmediawiki/extensions/VisualEditormaster+5 -3
DesktopArticleTarget.init: Support '&editintro=…' in edit linksmediawiki/extensions/VisualEditormaster+11 -4
Add editintro to noticesmediawiki/extensions/VisualEditormaster+22 -3
Customize query in gerrit

Related Objects

Event Timeline

• bzimport raised the priority of this task from to Lowest.Nov 22 2014, 2:09 AM
• bzimport added a project: VisualEditor-MediaWiki.
• bzimport set Reference to bz54029.
• Whatamidoing-WMF created this task.Sep 11 2013, 8:05 PM
SalixAlba added a comment.Sep 12 2013, 7:11 AM

Link for InputBox https://www.mediawiki.org/wiki/Extension:InputBox

SalixAlba added a comment.Sep 12 2013, 7:20 AM

To work as desired VE would need to respect the editintro= url parameter. For example
http://en.wikipedia.org/wiki/Paul_Bahn?veaction=edit&editintro=Template:BLP_editintro
and use that to fill in the edit notice with Template:BLP_editintro.
A couple of lines in MediaWiki:Common.js would add the parameters to URL's for all BLPs.

Jdforrester-WMF added a project: VisualEditor.Nov 24 2014, 4:10 PM
Jdforrester-WMF moved this task from To Triage to Freezer on the VisualEditor board.Nov 24 2014, 4:15 PM
TheDJ subscribed.Dec 2 2014, 8:28 AM

alternatively, get away from this specific implementation and try to move it into core as "category based edit notices" and VE gets the notice for free.

Cenarium subscribed.Dec 7 2014, 2:50 AM
Cenarium mentioned this in T85372: Add support for per-category editnotices.Dec 27 2014, 2:38 PM
Cenarium added a comment.Dec 27 2014, 2:44 PM
In T56029#800523, @TheDJ wrote:

alternatively, get away from this specific implementation and try to move it into core as "category based edit notices" and VE gets the notice for free.

I've created a specific task for per category editnotices, T85372, I had already suggested it for the more general T20596 but this didn't get implemented.
FYI, the English Wikipedia isn't the only wiki to use this.
Adding support in VE for preload / editintro is still worthy on its own, but it looks like this task is a duplicate of T51622.

-jem- subscribed.Jan 2 2015, 12:40 PM
Cenarium added a comment.Mar 8 2015, 1:36 PM

I've uploaded a patch for this (per-category editnotices) : commit 189178.

Krinkle unsubscribed.Mar 8 2015, 4:13 PM
Cenarium added a comment.May 25 2015, 8:43 PM
In T56029#1098976, @Cenarium wrote:

I've uploaded a patch for this (per-category editnotices) : commit 189178.

I've updated the patch, it works properly now.

Quiddity mentioned this in T51622: Add support for (the equivalent of?) editintro and preload.Jun 20 2015, 6:20 PM
Quiddity subscribed.
In T56029#945042, @Cenarium wrote:

Adding support in VE for preload / editintro is still worthy on its own, but it looks like this task is a duplicate of T51622.

Now Merging.

Quiddity closed this task as a duplicate of T51622: Add support for (the equivalent of?) editintro and preload.Jun 20 2015, 6:22 PM
Quiddity updated the task description. (Show Details)
Quiddity set Security to None.
Jdforrester-WMF reopened this task as Open.Jun 22 2015, 3:08 PM
Jdforrester-WMF raised the priority of this task from Lowest to Medium.
Jdforrester-WMF updated the task description. (Show Details)
Jdforrester-WMF added a project: VisualEditor 2015/16 Q1 blockers.
Jdforrester-WMF added a comment.Jun 22 2015, 3:11 PM

One way to fix this, as @Cenarium has observed, would be to fix T85372: Add support for per-category editnotices and switch wiki(?s) over to use that instead; is this the best option?

TheDJ added a comment.Jun 22 2015, 6:57 PM

I think it is better than editintro+JS yes.

TheDJ renamed this task from VisualEditor: Magically support Extension:InputBox's content for BLP warning notices on enwiki to VisualEditor: Provide support for BLP edit notices on enwiki.Jun 22 2015, 7:20 PM
Jdforrester-WMF moved this task from Nominated to Backlog: T1 on the VisualEditor 2015/16 Q1 blockers board.Jun 30 2015, 7:14 PM
Jdforrester-WMF edited a custom field.Jul 3 2015, 5:48 PM
Jdforrester-WMF moved this task from Freezer to TR1: Releases on the VisualEditor board.Jul 21 2015, 6:19 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 21 2015, 6:19 PM
Jdforrester-WMF removed a project: VisualEditor 2015/16 Q1 blockers.Jul 21 2015, 6:30 PM
Jdforrester-WMF added a subtask: T85372: Add support for per-category editnotices.Aug 7 2015, 4:06 PM
whym updated the task description. (Show Details)Mar 9 2016, 8:18 AM
Esanders mentioned this in T153481: New WikiText Editor fails when trying to edit articles with editintros.Dec 31 2016, 3:23 PM
gerritbot subscribed.Dec 31 2016, 5:03 PM

Change 329796 had a related patch set uploaded (by Esanders):
Add editintro to notices

https://gerrit.wikimedia.org/r/329796

Restricted Application added a subscriber: Stang. · View Herald TranscriptDec 31 2016, 5:03 PM
gerritbot added a project: Patch-For-Review.Dec 31 2016, 5:03 PM
gerritbot added a comment.Jan 3 2017, 8:19 PM

Change 329796 merged by jenkins-bot:
Add editintro to notices

https://gerrit.wikimedia.org/r/329796

Jack_who_built_the_house subscribed.EditedAug 7 2018, 6:08 PM

Just to make you know: in ruwiki, we adapted RockMFR's "magic editintros" to work with VisualEditor (although the resultant script is rather hackish), see https://ru.wikipedia.org/wiki/MediaWiki:Gadget-blpEditNotice.js.

TheDJ added a parent task: T201613: Unify 'edit notices' technology stack.Aug 9 2018, 2:11 PM
Proc subscribed.Jun 5 2021, 4:34 PM
Dbrant mentioned this in T201597: Android app does not present edit notices.Oct 24 2022, 1:54 PM
Tsevener mentioned this in T201596: iOS app does not present edit notices.Jan 17 2023, 11:26 PM
Pppery removed a project: Patch-For-Review.Apr 8 2023, 5:30 PM
Restricted Application added a subscriber: Ericliu1912. · View Herald TranscriptApr 8 2023, 5:30 PM
matmarex subscribed.Apr 20 2023, 1:08 AM

This already almost works. The API used by VE to fetch edit notices supports the 'editintro' parameter. In fact, if you follow this link, you'll see the notice: https://en.wikipedia.org/w/index.php?title=Jasmin_Fejzić&veaction=edit&editintro=Template:BLP_editintro. But if you just click "Edit" on the same page, you won't. This probably only needs a tiny bit of glue code to parse the parameters from the "Edit" link, like we're already parsing them from the URL.

matmarex removed a parent task: T201613: Unify 'edit notices' technology stack.Apr 20 2023, 1:08 AM
matmarex removed a subtask: T85372: Add support for per-category editnotices.
matmarex added a project: good first task.
Izno subscribed.Apr 20 2023, 1:11 AM
gerritbot added a comment.May 29 2023, 12:30 AM

Change 923769 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@master] DesktopArticleTarget.init: Support '&editintro=…' in edit links

https://gerrit.wikimedia.org/r/923769

gerritbot added a project: Patch-For-Review.May 29 2023, 12:30 AM
matmarex claimed this task.May 29 2023, 12:31 AM
matmarex added a project: Editing-team (Kanban Board).
matmarex moved this task from TR1: Releases to Triaged on the VisualEditor board.
matmarex moved this task from Incoming to Code Review on the Editing-team (Kanban Board) board.
gerritbot added a comment.May 30 2023, 5:19 PM

Change 923769 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] DesktopArticleTarget.init: Support '&editintro=…' in edit links

https://gerrit.wikimedia.org/r/923769

Maintenance_bot removed a project: Patch-For-Review.May 30 2023, 5:30 PM
ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.12; 2023-06-06).May 30 2023, 6:00 PM
matmarex edited projects, added Editing QA; removed good first task.May 30 2023, 6:38 PM
matmarex moved this task from Code Review to QA on the Editing-team (Kanban Board) board.

This should make the edit intros work.

There's one known issue: the edit intro message only appears the first time the editor is opened after loading/refreshing the page. (Afterwards editor initialization is done differently, and adding this feature without messing up the browser back/forward navigation proved difficult.) We should probably file a separate task about this.

Quiddity unsubscribed.May 30 2023, 8:49 PM
Ryasmeen added a comment.Jun 12 2023, 4:24 PM

It seems the edit intro message is appearing only when you load the page following the link that has the 'editintro' url parameter. But, it's still not showing the edit notice when you click on the 'Edit' button directly on the same page which I think what the new patch was for?

In T56029#8889645, @gerritbot wrote:

Change 923769 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] DesktopArticleTarget.init: Support '&editintro=…' in edit links

https://gerrit.wikimedia.org/r/923769

Here is the screen capture of the issue. Also, it seems the URL on the address bar is different from what it shows when you hover over the Edit link:

screen_capture.mov1003 KBDownload

This is different from the special case @matmarex mentioned here:

In T56029#8890073, @matmarex wrote:

This should make the edit intros work.

There's one known issue: the edit intro message only appears the first time the editor is opened after loading/refreshing the page. (Afterwards editor initialization is done differently, and adding this feature without messing up the browser back/forward navigation proved difficult.) We should probably file a separate task about this.

Ryasmeen moved this task from QA to Blocked / Needs More Work on the Editing-team (Kanban Board) board.Jun 12 2023, 4:24 PM
Ryasmeen removed a project: Editing QA.
gerritbot added a comment.Jun 20 2023, 10:15 AM

Change 931571 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@master] Fix '&editintro=…' not working on Vector with some settings

https://gerrit.wikimedia.org/r/931571

gerritbot added a project: Patch-For-Review.Jun 20 2023, 10:15 AM

Change 931572 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@master] Support '&editintro=…' etc. on back/forward and VE/NWE switch

https://gerrit.wikimedia.org/r/931572

gerritbot added a comment.Jun 20 2023, 10:15 AM

Change 931573 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@master] Support '&editintro=…' etc. on subsequent loads via page tabs

https://gerrit.wikimedia.org/r/931573

matmarex added a comment.Jun 20 2023, 10:17 AM

Thank you @Ryasmeen, I figured out why that was happening. It was only broken when using single edit tab mode, and I didn't think to test that before.

I also fixed the other issue, so after these changes, the message should appear after the editor is opened again as well.

matmarex moved this task from Blocked / Needs More Work to Code Review on the Editing-team (Kanban Board) board.Jun 20 2023, 10:17 AM
gerritbot added a comment.Jun 21 2023, 6:58 PM

Change 931571 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Fix '&editintro=…' not working on Vector with some settings

https://gerrit.wikimedia.org/r/931571

ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.15; 2023-06-27); removed MW-1.41-notes (1.41.0-wmf.12; 2023-06-06).Jun 21 2023, 7:00 PM
Pcoombe added a project: MediaWiki-Editnotice.Jul 3 2023, 9:19 PM
Ericliu1912 unsubscribed.Jul 10 2023, 12:22 AM
gerritbot added a comment.Jul 11 2023, 3:33 PM

Change 931572 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Support '&editintro=…' etc. on back/forward and VE/NWE switch

https://gerrit.wikimedia.org/r/931572

gerritbot added a comment.Jul 11 2023, 3:33 PM

Change 931573 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Support '&editintro=…' etc. on subsequent loads via page tabs

https://gerrit.wikimedia.org/r/931573

ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.18; 2023-07-18); removed MW-1.41-notes (1.41.0-wmf.15; 2023-06-27).Jul 11 2023, 4:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jul 11 2023, 4:12 PM
matmarex moved this task from Code Review to QA on the Editing-team (Kanban Board) board.Jul 11 2023, 4:39 PM
matmarex added a project: Editing QA.
Ryasmeen moved this task from QA to Ready for Sign Off on the Editing-team (Kanban Board) board.Jul 21 2023, 10:18 PM
Ryasmeen edited projects, added Verified; removed Editing QA.
• ppelberg closed this task as Resolved.Aug 23 2023, 12:13 AM
Stang unsubscribed.Aug 26 2023, 10:33 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL