Page MenuHomePhabricator

Port wmerrors / php-fatal-error.html to HHVM
Closed, ResolvedPublic

Description

I'm not sure how much of wmerrors need to be ported. HHVM appears to enhance PHP's error reporting capabilities in various (alas, mostly undocumented) ways, so perhaps some of the fancy footwork in wmerrors won't need to be ported. But at minimum, php-fatal-error.html should work.

See onFatalError, onUnhandledException in hphp/runtime/base/execution-context.cpp

https://github.com/facebook/hiphop-php/blob/4eb05b745fd3018a6d9e51464cae06a4465ee142/hphp/runtime/base/execution-context.cpp


Version: wmf-deployment
Severity: enhancement

Details

Reference
bz54163

Event Timeline

bzimport raised the priority of this task from to Normal.Nov 22 2014, 1:49 AM
bzimport set Reference to bz54163.
ori created this task.Sep 16 2013, 9:33 AM

[Using keyword instead of tracking bug for HipHop issues as requested in bug 40926 comment 5. Filter bugmail on this message.]

Looks like in HHVM we don't need to code our own extension to achieve both of wmerrors goals:

  • Logging stacktraces is configurable, e.g. https://gerrit.wikimedia.org/r/120162
  • Fancy error pages are doable by pointing ErrorDocument500 to a PHP file that uses error_get_last() to display the needed information.

Ping me when we will have a Puppet module for production and I'll help with configuring this.

aaron added a comment.Mar 23 2014, 9:43 PM

Max, feel like assigning this to yourself?

Is there anything left to assign?:)