Page MenuHomePhabricator

Autocreate not running on Special:CentralAutoLogin
Closed, ResolvedPublic

Description

DGarry (WMF) was hitting a bug today where he logged into enwiki, and SUL logged him into most of the other projects. But, his account wasn't attached on commons, and so that autologin attempt failed, with an error in the header saying the user didn't have an attached account.

When he logged in directly on commons, the account was autocreated correctly.

We should be autocreating the accounts, like used to happen with the old AutoLogin.


Version: master
Severity: normal

Details

Reference
bz54292

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 1:58 AM
bzimport set Reference to bz54292.

(In reply to comment #0)

his account wasn't attached
on
commons

Clarification to pre-SUL dinosaurs like me: it wasn't attached because it didn't exist at all locally. No local unattached accounts here, luckily.
[[Special:CentralAuth/DGarry (WMF)]]

Change 84998 had a related patch set uploaded by Anomie:
Don't fail autologin for unattached accounts

https://gerrit.wikimedia.org/r/84998

(In reply to comment #0)

We should be autocreating the accounts, like used to happen with the old
AutoLogin.

Actually the old code didn't autocreate the accounts either, it just set the cookies regardless of whether a local account existed or was attached. And that works fine, because it's exactly the same situation as if you log in to enwiki but some unattached account has your name on dewiki.

And if we did autocreate the account we'd still have the bug where if an unattached user existed on say en.wiktionary then the SUL user wouldn't be auto-logged-in to any other wiktionaries either.

So what we really need to do is not care about the local account for the icons. But we do still need to care about the scripts, or we'll re-cause bug 51603.

Change 84998 merged by jenkins-bot:
Don't fail autologin for unattached accounts

https://gerrit.wikimedia.org/r/84998