Page MenuHomePhabricator

$wgHideOpenIDLoginLink was not completely renamed to $wgOpenIDHideOpenIDLoginLink
Closed, ResolvedPublic


Grepping through the code shows no use of this variable outside of its declaration. It certainly doesn't remove the login link.

Version: master
Severity: normal



Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 2:13 AM
bzimport set Reference to bz54506.
Anomie created this task.Sep 24 2013, 4:19 PM

It looks like the name was changed to $wgHideOpenIDLoginLink. Setting $wgHideOpenIDLoginLink=true hides the link correctly. references the correct name.

Thanks for reporting.

All OpenID parameter names should have the form $wgOpenID......

It appears, that the renaming of this specific variable has been overlooked in the past. I will fix this begin of October.

Sorry for the inconvenience.

The bug is still a bug, it's not invalid. If the name should be $wgHideOpenIDLoginLink, then that should be listed in OpenID.php and $wgOpenIDHideOpenIDLoginLink shouldn't be. And if the name should be $wgOpenIDHideOpenIDLoginLink, then $wgHideOpenIDLoginLink needs to be replaced in the code and the documentation.

fixed, tested, merged, closed

solved with (why is gerrit not adding this information any more ?)

(In reply to comment #5)

solved with (why is gerrit not
adding this information any more ?)

Because you did not follow