Page MenuHomePhabricator

Missing message <mwe-upwiz-undefined>
Closed, ResolvedPublic

Description

Today I saw a few time the message place holder <mwe-upwiz-undefined> in the last step of the UploadWizard.


Version: unspecified
Severity: normal
Whiteboard: gci2013
URL: http://www.google-melange.com/gci/task/view/google/gci2013/5854794258317312

Details

Reference
bz54524

Related Objects

View Standalone Graph
This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:15 AM
bzimport set Reference to bz54524.
bzimport added a subscriber: Unknown Object (MLST).

I'm going to guess js error where mw-upwiz- is being concated with an undefined variable

Adding many blockers of bug 38638 to the list of "easy" bugs, to mark them as candidates for [[mw:Google Code-in]] tasks (gci2013). If you think this bug is not suitable, remove the keyword.

(In reply to comment #0)
Is this reproducible? or does this happen every time?

(In reply to comment #1)

I'm going to guess js error where mw-upwiz- is being concated with an
undefined
variable

Then, unless Raymond finds the place(s) where this happens consistently, this is what it takes to fix this:

  1. go through all the places where message keys are constructed and add all possibly resulting keys as code comments, per [[mw:Localisation#Using messages]];
  2. check that they all exist, fix/add them where missing.

A bit tedious but easy and needs to be done anyway, can we get a GCI task please? :)

maddiemadan wrote:

I think line 230 in mw.FormDataTransport and line 1341 in mw.UploadWizardDetails.js are the problems. response.upload.stage is returning undefined in the first one and result.upload.stage is returning undefined in the second one. I cant find any other problems in UW related to this bug

Change 104782 had a related patch set uploaded by Mayankmadan:
Adding code comments of resulting keys

https://gerrit.wikimedia.org/r/104782

maddiemadan wrote:

Is there a particular way to call the mw.UploadWizardDetails function?

Change 104782 merged by jenkins-bot:
Adding code comments of resulting keys

https://gerrit.wikimedia.org/r/104782

All patches were merged a while ago - is there more work left to do here (if yes: please reset the bug report status to NEW or ASSIGNED), or can you close this ticket as RESOLVED FIXED?

No reply to comment 9 - assuming this is fixed by the merged patch.

Gilles raised the priority of this task from Medium to Unbreak Now!.Dec 4 2014, 10:21 AM
Gilles moved this task from Untriaged to Done on the Multimedia board.
Gilles lowered the priority of this task from Unbreak Now! to Medium.Dec 4 2014, 11:20 AM