ISSN Magic Numbers
OpenPublic

Description

Author: fgregg

Description:
There was a request to add similar functionality for ISSN numbers as exists now for ISBN numbers. http://en.wikipedia.org/wiki/Wikipedia_talk:Book_sources

These files add this feature.


Version: unspecified
Severity: enhancement

bzimport added a project: MediaWiki-Special-pages.Via ConduitNov 21 2014, 8:52 PM
bzimport added a subscriber: wikibugs-l.
bzimport set Reference to bz3663.
bzimport created this task.Via LegacyOct 9 2005, 4:46 PM
bzimport added a comment.Via ConduitOct 9 2005, 4:48 PM

fgregg wrote:

patches Parser.php for ISSN magicnumbering

attachment ISSNpatch ignored as obsolete

bzimport added a comment.Via ConduitOct 9 2005, 4:49 PM

fgregg wrote:

Periodical Special Page

Attached: SpecialPeriodicalsources.php

bzimport added a comment.Via ConduitOct 9 2005, 6:13 PM

avarab wrote:

(In reply to comment #1)

Created an attachment (id=961) [edit]
patches Parser.php for ISSN magicnumbering

This patch is useless because the code that was supposed to use the function you
added is commented out, furthermore, making a new function to parse ISSN codes
rather than adding that functionality to the already existing ISBN function
(they're parsed almost in the same way),

bzimport added a comment.Via ConduitOct 25 2005, 9:07 AM

fgregg wrote:

patch responds to criticism, integrated with current ISBN code

attachment ISSNpatch ignored as obsolete

brion added a comment.Via ConduitDec 3 2005, 2:25 AM
  • Avoid mixing tabs and spaces; use tabs consistently
  • Please follow existing code conventions on code block usage
  • Will require patch to Sanitizer.php to protect against ISSN links in HTML

bits

  • Won't this not work without a patch to Booksources?
bzimport added a comment.Via ConduitDec 5 2005, 1:35 PM

fgregg wrote:

fixed formatting in response to Brion's comment

Attached: ISSNpatch

bzimport added a comment.Via ConduitDec 5 2005, 1:40 PM

fgregg wrote:

Patches Santitizer.php to catch ISSN links

Attached: ISSNSanitizerpatch

bzimport added a comment.Via ConduitDec 5 2005, 1:42 PM

fgregg wrote:

patches SpecialPage.php

Attached: ISSNSpecialpage

bzimport added a comment.Via ConduitDec 5 2005, 1:48 PM

fgregg wrote:

*Responded to Brion's comments about format
*Included patch to Sanitizer.php
*Changed patch so that ISSN pages go to SpecialPeriodicalsources.php
*Added patch to SpecialPage.php to include SpecialPeriodicalsources.php
*attachment 962 is SpecialPeriodicalsources.php

Question

What's the appropriate way to patch for messages

bzimport added a comment.Via ConduitDec 5 2006, 3:44 PM

ui2t5v002 wrote:

What is this for? ISBN is a label for a single book. ISSN is a label for an
entire journal; not individual articles or even volumes. What is going to be on
the "ISSN sources" page? A single link to the web site of the journal? What's
the point?

demon added a comment.Via ConduitMar 13 2009, 1:11 PM

WONTFIX'ing per comment 10 and lack of activity for 3 years.

bzimport added a comment.Via ConduitMar 13 2009, 1:14 PM

ayg wrote:

Lack of activity is never a legitimate reason for WONTFIXing, but I don't think we want more magic like ISBN and RFC. Better that those should be phased out in favor of templates at some point in the future.

MarkAHershberger added a comment.Via ConduitDec 2 2010, 7:00 PM

re-opening to depend on Bug #26207

demon added a comment.Via ConduitDec 23 2011, 7:53 PM

Removing need-review keyword. This absolutely depends on 26207 which presumably would handle this cleanly without requiring Sanitizer & Parser changes.

mxn added a subscriber: mxn.Via WebNov 24 2014, 8:51 PM
demon removed a subscriber: demon.Via WebDec 16 2014, 6:10 PM

Add Comment